Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presence of “, BC” in input string affects standardization choices by the Geocoder #229

Open
bstratto opened this issue Mar 2, 2021 · 2 comments

Comments

@bstratto
Copy link

bstratto commented Mar 2, 2021

NOTE: this is an isolated case.

In the address below, when the address is provided with “, BC” at the end, the Geocoder standardizes to an address that is different than when “, BC” is removed.

addressString: 201 36 W 1, NORTH VANCOUVER, BC
Geocodes to: UNIT 201 -- 36W Trans-Canada Hwy, West Vancouver, BC
Score: 90
Faults: [UNIT_DESIGNATOR.missing:0, UNIT_NUMBER.notMatched:1, LOCALITY.isAlias:1, STREET_NAME.isHighwayAlias:0, STREET_DIRECTION.notMatchedInHighway:0, STREET_TYPE.missing:6, STREET_TYPE.notSuffix:0, CIVIC_NUMBER_SUFFIX.notMatched:1, MAX_RESULTS.too_low_to_include_all_best_matches:0]

addressString: 201 36 W 1, NORTH VANCOUVER
Geocodes to: UNIT 201 -- 36 W 1st Ave, Vancouver, BC
Score: 88
Faults: [LOCALITY_GARBAGE.notAllowed:3, UNIT_DESIGNATOR.missing:0, UNIT_NUMBER.notMatched:1, STREET_TYPE.missing:6, PROVINCE.missing:1]

@cmhodgson
Copy link
Collaborator

This case is even more interesting - with the "BC" on the end, there are actually 5 different results with a score of 90.
One of them is "UNIT 201 -- 36W W Pender St, Vancouver, BC" which gets a "Street_Name.PartialMatch" penalty for the "1" to be a partial match of "pender"? AND the "W" gets a civic number suffix notMatched - (as in 36W) but why isn't the W just consumed by the "w" in "W pender"? Something funny is going on there.

Actually it seems like what is happening is that the "W" is being echoed as a civic number suffix (even though it should have been interpreted as the street directional, and this is affecting the scoring. If I set echo=false I get different results. I don't believe echo should be effecting the scoring. It also shouldn't be echoing things that are interpreted in other ways.

@cmhodgson
Copy link
Collaborator

Actually nevermind, all that can be explained - the "north" in north vancouver is being used as the directional for the "west pender", it is getting a Street_Direction.notMatchedInHighway fault. Meanwhile the 1 is a partial match for highway "1A" which apparently is an alias for west pender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants