-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swift_c_module "does not have mandatory providers: 'cc'" with bazel 0.22 #123
Comments
I believe it's this: bazelbuild/bazel@a60b6ce There have been a number of changes to the C++ providers recently that I've been waiting to become finalized enough that I can adopt them. |
Confirmed that setting |
Is this something we can migrate now? Or would we have to support both at once? I haven't looked for when the new providers were added |
It looks like the same conversation is happening here bazelbuild/bazel#7036 (comment) |
@allevato is this something you're planning on working on before the 0.22 release? |
I'll start working on the migration this week, but the currently released version of Bazel that we use internally doesn't yet include the above commit yet, so I can't release anything until we catch up to that. I looked into support both simultaneously, but the effort would be fairly large since the old- and new-style providers are very different, and I can't rationalize that amount of effort for a short-term workaround. If Bazel releases 0.22 before I'm able to fully test the change internally and push it out, then I'd recommend using |
I've commented on the linked issue asking about the migration window, it doesn't seem like 0.22 has the necessary files I expected. I've submitted a first pass PR for this that is compatible with bazel HEAD right now #129 |
My PR is green now so we should be good for compatibility with 0.22! |
I believe this is resolved now. |
With the bazel 0.22rc2 pre-release (from here), with this WORKSPACE:
And this in the BUILD file:
I end up with this build error:
I'm not sure what change in bazel has caused this yet
The text was updated successfully, but these errors were encountered: