fix(create): make --packageManager flag work (#3498)

bazel-contrib · Jul 3, 2022 · cd3db48 · cd3db48
1 parent 463d4e7
commit cd3db48
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/packages/create/index.js b/packages/create/index.js
@@ -75,7 +75,15 @@ function main(argv, error = console.error, log = console.log) {
   }
 
   // Which package manager will be used in the new project
-  const pkgMgr = args['packageManager'] || detectRunningUnderYarn() ? 'yarn' : 'npm';
+  let pkgMgr = args['packageManager'];
+
+  if (!pkgMgr) {
+    pkgMgr = detectRunningUnderYarn() ? 'yarn' : 'npm';
+  } else if(pkgMgr !== 'yarn' && pkgMgr !== 'npm') {
+    error('Please select between \'yarn\' and \'npm\' when providing --packageManager');
+    usage(error);
+    return 1;
+  }
 
   log_verbose('Running with', process.argv);
   log_verbose('Environment', process.env);

diff --git a/packages/create/test.js b/packages/create/test.js
@@ -70,6 +70,16 @@ wkspContent = read('default_to_yarn/WORKSPACE');
 if (wkspContent.indexOf('yarn_install(') < 0) {
   fail('should use yarn by default');
 }
+
+exitCode = main(['use_npm_with_yarn', '--packageManager=npm']);
+if (exitCode != 0) fail('should be success');
+wkspContent = read('use_npm_with_yarn/WORKSPACE');
+if (wkspContent.indexOf('npm_install(') < 0) {
+  fail('should use npm as selected');
+}
+
+exitCode = main(['neither_yarn_nor_npm', '--packageManager=foo']);
+if (exitCode != 1) fail('should exit 1 when selecting neither \'yarn\' nor \'npm\'');
 // TODO: run bazel in the new directory to verify a build works
 
 exitCode = main(['--typescript', 'with_ts'], captureError);