-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Split pt translation into pt (EU) and pt_BR (Brazil) #694
Conversation
dhanielo
commented
Aug 15, 2023
•
edited
Loading
edited
- Add support to the language nuances between European Portuguese 🇪🇺🇵🇹 and Brazilian Portuguese 🇧🇷.
- Improve coverage for "pt", "pt_BR" languages to the builder editor
- Implements i18n fallback to "en" when translations are missing
Someone is attempting to deploy a commit to the Typebot Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Can you merge your other PR (#698) with this one? |
Yes, I can. I'm just adding more translations in the code, and after that, I'll merge both. 💪 |
That's awesome thank you! Let me know if you need help with that :) |
af0e727
to
793218a
Compare
Hi @baptisteArno I'm still working on it however may you take a look to guarantee it's going in the right way once this PR can be a bit huge? |
That looks good but I need to take a closer look. Can we avoid translating the entire app? Can we stop at some point and continue in another pull request so that it's easier to digest? Let me know |
Yes sounds good, on this PR I tried to focus on the editor and add the fallback to en. We can stop at this point and I can create other PR to continue 💪🏼 |
Ok, let's pause here. Let me review that! |
Had to open another PR so that I can edit some things #767 |
Original PR: #694 --------- Co-authored-by: Daniel Oliveira <daniel.oliveira@kununu.com> Co-authored-by: Daniel Oliveira <daniel@headdev.com.br>