Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Split pt translation into pt (EU) and pt_BR (Brazil) #694

Closed
wants to merge 11 commits into from
Closed

🌐 Split pt translation into pt (EU) and pt_BR (Brazil) #694

wants to merge 11 commits into from

Conversation

dhanielo
Copy link
Contributor

@dhanielo dhanielo commented Aug 15, 2023 •
edited
Loading

  • Add support to the language nuances between European Portuguese 🇪🇺🇵🇹 and Brazilian Portuguese 🇧🇷.
  • Improve coverage for "pt", "pt_BR" languages to the builder editor
  • Implements i18n fallback to "en" when translations are missing

@vercel
Copy link

vercel bot commented Aug 15, 2023

Someone is attempting to deploy a commit to the Typebot Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 6:29pm

@dhanielo dhanielo changed the title Split pt translation into pt (EU) and pt_BR (Brazil) 🌐 Split pt translation into pt (EU) and pt_BR (Brazil) Aug 15, 2023
@baptisteArno
Copy link
Owner

Can you merge your other PR (#698) with this one?

@dhanielo
Copy link
Contributor Author

Can you merge your other PR (#698) with this one?

Yes, I can. I'm just adding more translations in the code, and after that, I'll merge both. 💪

@dhanielo dhanielo marked this pull request as draft August 18, 2023 12:44
@baptisteArno
Copy link
Owner

That's awesome thank you! Let me know if you need help with that :)

@dhanielo dhanielo marked this pull request as ready for review August 31, 2023 00:43
@dhanielo
Copy link
Contributor Author

That's awesome thank you! Let me know if you need help with that :)

Hi @baptisteArno I'm still working on it however may you take a look to guarantee it's going in the right way once this PR can be a bit huge?

@baptisteArno
Copy link
Owner

That looks good but I need to take a closer look. Can we avoid translating the entire app? Can we stop at some point and continue in another pull request so that it's easier to digest?

Let me know

@dhanielo dhanielo closed this Aug 31, 2023
@dhanielo dhanielo reopened this Aug 31, 2023
@dhanielo
Copy link
Contributor Author

That looks good but I need to take a closer look. Can we avoid translating the entire app? Can we stop at some point and continue in another pull request so that it's easier to digest?

Let me know

Yes sounds good, on this PR I tried to focus on the editor and add the fallback to en. We can stop at this point and I can create other PR to continue 💪🏼

@baptisteArno
Copy link
Owner

Ok, let's pause here. Let me review that!

@baptisteArno baptisteArno mentioned this pull request Sep 5, 2023
Merged
@baptisteArno
Copy link
Owner

Had to open another PR so that I can edit some things #767

baptisteArno added a commit that referenced this pull request Sep 5, 2023
@baptisteArno @dhanielo
🌐 Add pt_BR and more translations (#767)
aaa208c 
Original PR: #694

---------

Co-authored-by: Daniel Oliveira <daniel.oliveira@kununu.com>
Co-authored-by: Daniel Oliveira <daniel@headdev.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhanielo @baptisteArno