fix(editor): 🐛 Fix edge on item offset top on drop

baptisteArno · Mar 28, 2022 · c64afb7 · c64afb7 · vercel · Mar 28, 2022
1 parent 43fa411
commit c64afb7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/apps/builder/components/shared/Graph/Nodes/ItemNode/ItemNodesList.tsx b/apps/builder/components/shared/Graph/Nodes/ItemNode/ItemNodesList.tsx
@@ -72,12 +72,12 @@ export const ItemNodesList = ({
     if (!isDraggingOnCurrentBlock) return
     const itemIndex = computeNearestPlaceholderIndex(e.pageY, placeholderRefs)
     e.stopPropagation()
+    setDraggedItem(undefined)
     createItem(draggedItem as ButtonItem, {
       blockIndex,
       stepIndex,
       itemIndex,
     })
-    setDraggedItem(undefined)
   }
   useEventListener(
     'mouseup',

diff --git a/apps/builder/contexts/TypebotContext/actions/steps.ts b/apps/builder/contexts/TypebotContext/actions/steps.ts
@@ -117,9 +117,8 @@ const moveStepToBlock = (
   const items = stepHasItems(step) ? step.items : []
   items.forEach((item) => {
     const edgeIndex = typebot.edges.findIndex(byId(item.outgoingEdgeId))
-    edgeIndex !== -1
-      ? (typebot.edges[edgeIndex].from.blockId = blockId)
-      : (newStep.outgoingEdgeId = undefined)
+    if (edgeIndex === -1) return
+    typebot.edges[edgeIndex].from.blockId = blockId
   })
   if (step.outgoingEdgeId) {
     if (typebot.blocks[blockIndex].steps.length > stepIndex ?? 0) {