fix(editor): 🐛 Fix basic auth header without ':'

baptisteArno · Feb 28, 2022 · 8552cc2 · 8552cc2 · vercel · Feb 28, 2022
1 parent b0d7be4
commit 8552cc2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/apps/builder/layouts/dashboard/TemplatesContent.tsx b/apps/builder/layouts/dashboard/TemplatesContent.tsx
@@ -39,7 +39,6 @@ export const TemplatesContent = () => {
     const { error, data } = typebot
       ? await importTypebot({
           ...typebot,
-          id: generate(),
           ownerId: user.id,
           folderId,
         })

diff --git a/apps/builder/services/typebots/typebots.ts b/apps/builder/services/typebots/typebots.ts
@@ -91,12 +91,21 @@ export const createTypebot = async ({
   })
 }
 
-export const importTypebot = async (typebot: Typebot) =>
-  sendRequest<Typebot>({
+export const importTypebot = async (typebot: Typebot) => {
+  const typebotToImport: Omit<Typebot, 'id'> = omit(
+    {
+      ...typebot,
+      publishedTypebotId: null,
+      publicId: null,
+    },
+    'id'
+  )
+  return sendRequest<Typebot>({
     url: `/api/typebots`,
     method: 'POST',
-    body: typebot,
+    body: typebotToImport,
   })
+}
 
 export const duplicateTypebot = async (typebotId: string) => {
   const { data } = await getTypebot(typebotId)

diff --git a/apps/viewer/pages/api/typebots/[typebotId]/blocks/[blockId]/steps/[stepId]/executeWebhook.ts b/apps/viewer/pages/api/typebots/[typebotId]/blocks/[blockId]/steps/[stepId]/executeWebhook.ts
@@ -68,7 +68,10 @@ const executeWebhook =
         h.key?.toLowerCase() === 'authorization' &&
         h.value?.toLowerCase()?.includes('basic')
     )
-    if (basicAuthHeaderIdx !== -1) {
+    const isUsernamePasswordBasicAuth =
+      basicAuthHeaderIdx !== -1 &&
+      webhook.headers[basicAuthHeaderIdx].value?.includes(':')
+    if (isUsernamePasswordBasicAuth) {
       const [username, password] =
         webhook.headers[basicAuthHeaderIdx].value?.slice(6).split(':') ?? []
       basicAuth.username = username