Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use poetry #67

Open
teucer opened this issue Mar 8, 2022 · 7 comments
Open

use poetry #67

teucer opened this issue Mar 8, 2022 · 7 comments

Comments

@teucer
Copy link
Contributor

teucer commented Mar 8, 2022

I think it would be helpful to use poetry for dependency management and package building process.

@tomicapretto
Copy link
Collaborator

I've seen Poetry in other projects, but I'm not very aware of its advantages over what we already have. What would be different/better with Poetry? (asking from an ignorant perspective, I'm not familiar with it)

@teucer
Copy link
Contributor Author

teucer commented Mar 8, 2022

This link explains the use.

In a nutshell: poetry helps to specify, install, and resolve external packages. It also supports to deploy to pypi. No need to have setup or requirements files.

@teucer
Copy link
Contributor Author

teucer commented Mar 9, 2022

Please let me know if this is something that you would like to do: I can send a PR...

@tomicapretto
Copy link
Collaborator

I prefer to keep the project as it is in terms of tools for dependency management, package building, etc.

I understand Poetry is helpful. But in our case everything we need is already working so I don't think it is a good time to change it. It implies some work and I don't see the benefits now.

@teucer
Copy link
Contributor Author

teucer commented Mar 10, 2022

Point taken. I still think poetry would open the door for an easier setup for development purposes, hence more contributors. It is as easy as "poetry install".

@tomicapretto
Copy link
Collaborator

I understand. Maybe once I use poetry in another project and understand the benefits we can revisit this issue here.

@wd60622
Copy link
Contributor

wd60622 commented Jun 22, 2023

Even though I'm a poetry fan, the setup is pretty straight forward.

pyenv local 3.9
python -m venv .venv
source .venv/bin/activate
python -m pip install -e .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants