Remove external links and unused datasets #483
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 90.47% 90.47%
=======================================
Files 29 29
Lines 2320 2320
=======================================
Hits 2099 2099
Misses 221 221
Continue to review full report at Codecov.
|
|
View / edit / reply to this conversation on ReviewNB canyon289 commented on 2022-04-10T02:19:40Z Should you start preemptively calling things pymc? tomicapretto commented on 2022-04-11T11:44:13Z Bambi still uses PyMC3. I think it's safer to call it PyMC until we change to PyMC (v4). |
|
View / edit / reply to this conversation on ReviewNB canyon289 commented on 2022-04-10T02:19:40Z Id advise figuring out a namespace for bambi like bmb, especially as this is a tutorial notebook. This will help reinforce good practice. A bit picky I know so feel free to ignore
tomicapretto commented on 2022-04-11T11:44:40Z Makes sense! |
| filename="admissions.csv", | ||
| url="https://figshare.com/ndownloader/files/34757857", | ||
| checksum="41e2312ca09d50e99c2db67fbabc78d215df6ce71eefe880df5e9310a9fa8397", | ||
| description="""Admission into graduate school data. This dataset has a binary response |
There was a problem hiding this comment.
| description="""Admission into graduate school data. This dataset has a binary response | |
| description=("Admission into graduate school data. This dataset has a binary response", | |
| "variable called 'admit'. There are three predictor variables: 'gre', 'gpa' and 'rank'.") |
I believe this will get you the string without the unneeded line break
|
Bambi still uses PyMC3. I think it's safer to call it PyMC until we change to PyMC (v4). View entire conversation on ReviewNB |
|
Makes sense! View entire conversation on ReviewNB |
This PR closes #476.
It also removes datasets under
docs/notebooks/datathat aren't accessed anymore, since we havebmb.load_data().