Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Reuse the package resolution and bal tool utility methods in Build tool logic #42348

Closed
gayaldassanayake opened this issue Mar 19, 2024 · 0 comments · Fixed by #42371
Labels
Area/ProjectAPI Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Improvement

Comments

@gayaldassanayake
Copy link
Contributor

Description

There are utility functions in the RunBuildToolsTask, BuildToolResolution, and BuildToolUtility classes that are similar to the already existing logic.

Describe your problem(s)

Code duplication can cause issues in the future. However, the reusing might not be straight-forward since there are minor changes in the logic.

Describe your solution(s)

We need to reuse the same code as much as possible. Methods like getSticky, pullLocallyUnavailableTools, isToolLocallyAvailable, getPackageLockingMode.

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/ProjectAPI Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants