Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Fix system module vulnerability #41258

Closed
kalaiyarasiganeshalingam opened this issue Aug 21, 2023 · 1 comment
Closed

[Task]: Fix system module vulnerability #41258

kalaiyarasiganeshalingam opened this issue Aug 21, 2023 · 1 comment

Comments

@kalaiyarasiganeshalingam
Copy link
Contributor

Description

Fix the following reported vulnerability :

This call to java.lang.ProcessBuilder.start() contains a command injection flaw.
The argument to the function is constructed using untrusted input.
If an attacker is allowed to specify all or part of the command, it may be possible to execute commands on the server with the privileges of the executing process.
The level of exposure depends on the effectiveness of input validation routines, if any.
start() was called on the pb object, which contains tainted data.
The tainted data originated from earlier calls to java.lang.Process.getErrorStream, and java.lang.Process.getInputStream.

Validate all untrusted input to ensure that it conforms to the expected format, using centralized data validation routines when possible.
When using blocklists, be sure that the sanitizing routine performs a sufficient number of iterations to remove all instances of disallowed characters.
Most APIs that execute system commands also have a ""safe"" version of the method that takes an array of strings as input rather than a single string, which protects against some forms of command injection.

References: 
CWE (https://cwe.mitre.org/data/definitions/78.html) 
OWASP (https://owasp.org/www-community/attacks/Command_Injection)

Describe your task(s)

No response

Related area

-> Standard Library

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@ballerina-bot ballerina-bot transferred this issue from ballerina-platform/ballerina-lang Aug 21, 2023
@kalaiyarasiganeshalingam kalaiyarasiganeshalingam transferred this issue from ballerina-platform/ballerina-library Aug 21, 2023
@kalaiyarasiganeshalingam
Copy link
Contributor Author

Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant