Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Remove redundant central calls for CLI commands after java 17 migration #41190

Closed
gayaldassanayake opened this issue Aug 11, 2023 · 1 comment · Fixed by #41209
Closed
Assignees
Labels
Area/ProjectAPI Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Bug
Milestone

Comments

@gayaldassanayake
Copy link
Contributor

Description

In the CLI commands, we have iterated through the SupportedPlatforms array and for each of the value in the array, we send central API calls with Ballerina-Platform set to each value. This is to filter out packages that are built with the specific platform.

However, this array previously contained only java11. (SUPPORTED_PLATFORMS = {"java11"}). Therefore only one request was sent.

Now with the addition of java17, SUPPORTED_PLATFORMS = {"java11", "java17"} has caused a lot of requests within cli commands including bal pull, bal search, bal tool search, bal tool pull to be duplicated doing the same thing twice.

Steps to Reproduce

Type bal search with the latest lang master build.

Affected Version(s)

2201.8.0-SNAPSHOT

OS, DB, other environment details and versions

No response

Related area

-> Other Area

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

@ballerina-bot ballerina-bot added the needTriage The issue has to be inspected and labeled manually label Aug 11, 2023
@gayaldassanayake gayaldassanayake added Area/ProjectAPI Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) and removed needTriage The issue has to be inspected and labeled manually labels Aug 11, 2023
@gayaldassanayake gayaldassanayake added this to the 2201.8.0 milestone Aug 11, 2023
@gayaldassanayake gayaldassanayake linked a pull request Aug 15, 2023 that will close this issue
13 tasks
@github-actions
Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

@gayaldassanayake gayaldassanayake added the Reason/EngineeringMistake The issue occurred due to a mistake made in the past. label Aug 17, 2023
@gayaldassanayake gayaldassanayake self-assigned this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/ProjectAPI Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants