Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve completions in Service Declaration node context #36635

Closed
malinthar opened this issue Jun 21, 2022 · 0 comments · Fixed by #41216
Closed

Improve completions in Service Declaration node context #36635

malinthar opened this issue Jun 21, 2022 · 0 comments · Fixed by #41216
Assignees
Labels
Area/Completion Issues related to Language Server Auto Completions Points/2 Equivalent to two days effort Priority/High Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Improvement
Milestone

Comments

@malinthar
Copy link
Contributor

Description:
image

http:Client cli = check new http:Client("");
websub:Listener websubLi = check new websub:Listener(9090);
listener http:Listener httpListener = check new http:Listener(9091);

service on <cursor>  {
    
}

Following improvements can be done in the depicted cursor position

  1. The listener declaration httpListener should be sorted to the top
  2. We don't suggest visible symbols at the cursor position expect for the listener declarations. We should suggest them even if the are not assignable in the context. For example the websubLi is not a listener declaration. But we can use the following code action to convert it to a listener declaration after providing the completion item.

Screenshot from 2022-06-21 11-43-37

Describe your problem(s)

Describe your solution(s)

Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

@gimantha gimantha added Team/CompilerFETools Semantic API, Formatter, Shell Team/LanguageServer Language Server Implementation related issues. #Compiler labels Sep 30, 2022
@LakshanWeerasinghe LakshanWeerasinghe removed the Team/CompilerFETools Semantic API, Formatter, Shell label Oct 20, 2022
@mindula mindula added Priority/High Area/Completion Issues related to Language Server Auto Completions labels Jul 10, 2023
@KavinduZoysa KavinduZoysa added the Points/2 Equivalent to two days effort label Jul 13, 2023
@KavinduZoysa KavinduZoysa self-assigned this Jul 14, 2023
@malinthar malinthar added this to the 2201.8.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Completion Issues related to Language Server Auto Completions Points/2 Equivalent to two days effort Priority/High Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Improvement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants