Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support large list/map constructors #33534

Closed
manuranga opened this issue Oct 30, 2021 · 0 comments · Fixed by #41017
Closed

Support large list/map constructors #33534

manuranga opened this issue Oct 30, 2021 · 0 comments · Fixed by #41017
Assignees
Labels
Points/3 Equivalent to three days effort Priority/High Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Type/Improvement

Comments

@manuranga
Copy link
Contributor

It has been previously reported and fixes that the list constructor at https://github.com/ballerina-platform/nballerina/blob/fca28a11dadf2a78b6cb010690505a184fd16020/compiler/modules/front.syntax/tests/testParser.bal#L189 is giving method too large error.

It is reappearing as we keep adding more items to the list. We are planning to move away from having it in source to a separate JSON file. With this, jBallerina will lose a valuable real world test case of having large constructors in files.

Since working with JSONs is a primary use case for ballerina, I think it will be common for users to paste huge JSON files into source code. I propose we plan for the by having an integration test with large constructors for both map and lists. We should also guarantee the compilation time is not affected by large constructors.

@manuranga manuranga added Type/Improvement Priority/High Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime labels Oct 30, 2021
@manuranga manuranga changed the title Support large large list/map constructors Support large list/map constructors Oct 30, 2021
@warunalakshitha warunalakshitha added Points/4 Equivalent to four day effort Points/3 Equivalent to three days effort and removed Points/4 Equivalent to four day effort labels Nov 19, 2021
@warunalakshitha warunalakshitha added Points/2 Equivalent to two days effort and removed Points/3 Equivalent to three days effort labels Dec 6, 2021
@warunalakshitha warunalakshitha added Points/3 Equivalent to three days effort and removed Points/2 Equivalent to two days effort labels Dec 6, 2021
@Nadeeshan96 Nadeeshan96 self-assigned this Jul 20, 2023
@warunalakshitha warunalakshitha removed their assignment Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Points/3 Equivalent to three days effort Priority/High Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime Type/Improvement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants