Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching layer to Parser, for caching the Compilation units #14214

Closed
2 tasks done
nadeeshaan opened this issue Mar 8, 2019 · 1 comment · Fixed by #20254
Closed
2 tasks done

Caching layer to Parser, for caching the Compilation units #14214

nadeeshaan opened this issue Mar 8, 2019 · 1 comment · Fixed by #20254
Assignees
@nadeeshaan @hasithaa
Labels
Area/Compiler Priority/High Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Team/CompilerFETools Semantic API, Formatter, Shell Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Improvement
Milestone
Ballerina 1.1.0

Comments

@nadeeshaan
Copy link
Contributor

nadeeshaan commented Mar 8, 2019 •
edited
Loading

Description:
For each parse current parser implementation parses the source and when there are considerably a larger amount of files, parsing phase takes significant time and language server compilation phases lag.
Following two tasks need to address

  • Caching the compilation unit
  • Caching the Syntax diagnostics

Affected Versions:
v0.990.3 at least
@nadeeshaan nadeeshaan added Priority/High Area/Compiler Team/LanguageServer Language Server Implementation related issues. #Compiler labels Mar 8, 2019
@nadeeshaan nadeeshaan self-assigned this Mar 8, 2019
@shafreenAnfar shafreenAnfar mentioned this issue Mar 11, 2019
Closed
@nadeeshaan nadeeshaan added this to the 0.995.0 milestone Mar 12, 2019
@nadeeshaan nadeeshaan mentioned this issue Mar 17, 2019
Closed
@nadeeshaan
Copy link
Contributor Author

Refer Thread https://groups.google.com/d/msg/ballerina-dev/YjfbZtH7z9o/lVCXySp2AAAJ

@kaviththiranga kaviththiranga removed this from the 0.995.0 milestone Mar 21, 2019
@anupama-pathirage anupama-pathirage added Team/CompilerFETools Semantic API, Formatter, Shell Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. labels Apr 30, 2019
@rdhananjaya rdhananjaya added this to the Ballerina 1.1.0 milestone Oct 17, 2019
@gimantha gimantha added the Points/5 Equivalent to five day effort label Nov 1, 2019
@rdhananjaya rdhananjaya added Points/2 Equivalent to two days effort and removed Points/5 Equivalent to five day effort labels Nov 29, 2019
@hasithaa hasithaa mentioned this issue Dec 3, 2019
Closed
14 tasks
@hasithaa hasithaa mentioned this issue Dec 6, 2019
Merged
13 tasks
@hasithaa hasithaa removed the Points/2 Equivalent to two days effort label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadeeshaan nadeeshaan

@hasithaa hasithaa

Labels
Area/Compiler Priority/High Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Team/CompilerFETools Semantic API, Formatter, Shell Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Improvement
Projects
None yet
Milestone
Ballerina 1.1.0
6 participants
@nadeeshaan @hasithaa @rdhananjaya @kaviththiranga @gimantha @anupama-pathirage