Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize some examples teamcity azuredevops travis [uptimerobot vaadin vscode-marketplace] #2444

Merged
merged 7 commits into from
Dec 4, 2018
Merged

Modernize some examples teamcity azuredevops travis [uptimerobot vaadin vscode-marketplace] #2444

merged 7 commits into from
Dec 4, 2018

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Dec 3, 2018 •
edited
Loading

Ref #1961

@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Dec 3, 2018
@shields-ci
Copy link

shields-ci commented Dec 3, 2018 •
edited
Loading

Warnings
⚠️ This PR modified service code for azure-devops but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for teamcity but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for travis but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for uptimerobot but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for vaadin-directory but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for vscode-marketplace but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow changed the title Modernize some examples [teamcity travis uptimerobot vaadin vscode-marketplace] Modernize some examples teamcity [travis uptimerobot vaadin vscode-marketplace] Dec 3, 2018
@paulmelnikow paulmelnikow changed the title Modernize some examples teamcity [travis uptimerobot vaadin vscode-marketplace] Modernize some examples teamcity [travis uptimerobot vaadin vscode-marketplace azuredevops] Dec 3, 2018
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2444 December 3, 2018 21:08 Inactive
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2444 December 3, 2018 21:11 Inactive
@paulmelnikow paulmelnikow changed the title Modernize some examples teamcity [travis uptimerobot vaadin vscode-marketplace azuredevops] Modernize some examples teamcity azuredevops [travis uptimerobot vaadin vscode-marketplace] Dec 3, 2018
@paulmelnikow
Copy link
Member Author

Azure failures are unrelated: #2412 (comment)

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2444 December 3, 2018 21:31 Inactive
@paulmelnikow
Copy link
Member Author

UptimeRobot is also timing out in master and I'm pretty sure the code here is still working.

@paulmelnikow paulmelnikow changed the title Modernize some examples teamcity azuredevops [travis uptimerobot vaadin vscode-marketplace] Modernize some examples teamcity azuredevops uptimerobot [travis vaadin vscode-marketplace] Dec 3, 2018
RedSparr0w
RedSparr0w approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@RedSparr0w RedSparr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
👍

@paulmelnikow paulmelnikow changed the title Modernize some examples teamcity azuredevops uptimerobot [travis vaadin vscode-marketplace] Modernize some examples teamcity azuredevops [uptimerobot travis vaadin vscode-marketplace] Dec 4, 2018
@paulmelnikow paulmelnikow changed the title Modernize some examples teamcity azuredevops [uptimerobot travis vaadin vscode-marketplace] Modernize some examples teamcity azuredevops travis [uptimerobot vaadin vscode-marketplace] Dec 4, 2018
@paulmelnikow
Copy link
Member Author

Uptimerobot working, but travis now failing for unrelated reasons.

@paulmelnikow paulmelnikow merged commit a35e877 into master Dec 4, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the examples branch December 4, 2018 21:44
@paulmelnikow paulmelnikow mentioned this pull request Dec 10, 2018
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedSparr0w RedSparr0w RedSparr0w approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmelnikow @shields-ci @RedSparr0w