-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
//@flow | ||
|
||
import { SemVer } from "semver"; | ||
import { SemVer, lt } from "semver"; | ||
import { logPluginOrPolyfill } from "./debug"; | ||
import getOptionSpecificExcludesFor from "./get-option-specific-excludes"; | ||
import { removeUnnecessaryItems } from "./filter-items"; | ||
|
@@ -295,6 +295,10 @@ export default declare((api, opts) => { | |
let targets = babelTargets; | ||
|
||
if ( | ||
// @babel/core < 7.13.0 doesn't load targets (api.targets() always | ||
// returns {} thanks to @babel/helper-plugin-utils), so we always want | ||
// to fallback to the old targets behavior in this case. | ||
lt(api.version, "7.13.0") || | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
fabiooshiro
via email
|
||
// If any browserslist-related option is specified, fallback to the old | ||
// behavior of not using the targets specified in the top-level options. | ||
opts.targets || | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import * as babel7_12 from "@babel/core"; | ||
import env from ".."; | ||
import path from "path"; | ||
|
||
describe("#12880", () => { | ||
it("read the .browserslistrc file when using @babel/core < 7.13.0", () => { | ||
// The browserslistrc file contains "firefox 50". | ||
// a ** b is supported starting from firefox 52; | ||
// a => b is supported starting from firefox 45. | ||
const out = babel7_12.transformSync("a ** b; a => b;", { | ||
configFile: false, | ||
presets: [[env, { modules: false }]], | ||
filename: path.join(__dirname, "regressions", "input.js"), | ||
}); | ||
|
||
expect(out.code).toMatchInlineSnapshot(` | ||
"Math.pow(a, b); | ||
a => b;" | ||
`); | ||
}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
firefox 50 |
hi @nicolo-ribaudo I think that change is braking the parcel-bundler, because the parcel does not pass the api.version
If there is no api.version it should be evaluated as false?