-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incomprehensible errors #10
Comments
Hmm, difficult to diagnose from just the stack traces. Could you share:
As well as try to build a minimal reproduction (just delete code until just before the error goes away)? |
|
error occurs on each file |
Facing the same issues here as well |
I just ran into something similar..
prettier@1.13.7 |
P.S. I got even more of them and seems it doesn't format as expected by TSLint. |
|
I can confirm this happens in our code. Is someone working in this ATM? This issue have a long time. |
@azz I created a minimal repo that reproduces this issue (for me, at least) |
I'm also getting these errors. It's strange because I'm using VS code with the prettiter-vscode extension which internally uses prettier-tslint and everything works perfectly. |
I also have these errors on a new project using # Runs "node_modules/.bin/prettier-tslint fix 'src/**/*.ts'"
yarn prettier-tslint fix 'src/**/*.ts' This is happening with the following versions (ascertained by using
@azz is there anything else that would help figuring this out? Would you prefer that we open a new issue for this? Seems like it could be similar to this issue: palantir/tslint#3711 Excerpt of error messages:
|
I get the same type of errors when I run
The result of this is almost perfect compared with the result I get when I run prettier with vs code having They have a comment there basically saying that they use this plugin so it's strange how that one works and the command line doesn't. "Use 'prettier-tslint' instead of 'prettier'. Other settings will only be fallbacks in case they could not be inferred from tslint rules." |
In this project that I'm working in, |
Yeah I'm having this issue, too. Same config as @adyz. |
The CLI is running this code: const linter = new tslint.Linter({ fix }, program); While prettier-vscode is running this code: const linter = new tslint.Linter({
fix: false,
formatter: "json",
}); When I removed the This module is pretty much the equivalent of running Prettier then TSLint with the prettier --write **/*.ts && tslint --fix --project . |
@kramerc's solution is pretty much what I went with. No need for prettier-tslint, really! |
Not true if you use |
@aleclarson At vscode-icons we use prettier with |
@JimiC If you install |
Closing this issue. If anyone here is still having problems, please open a new issue and provide a minimal repro. You can use this repo as a starting point. |
Looks like many errors were being caused by an undefined |
The text was updated successfully, but these errors were encountered: