Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix map bug #31

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Fix map bug #31

merged 2 commits into from
Jul 29, 2022

Conversation

azra-l
Copy link
Owner

@azra-l azra-l commented Jul 29, 2022

There is a known issue with mapbox where the latest version doesn't transpile properly on production builds of react apps.
This PR fixes the issue with this workaround: visgl/react-map-gl#1266 (comment)

To replicate:

  • On develop cd into react-app run npm run build and serve your build
  • Go into a detailed results page and notice the map is empty

before:
Screen Shot 2022-07-29 at 9 21 16 AM

after:
Screen Shot 2022-07-29 at 9 21 06 AM

@StanfordLin StanfordLin changed the base branch from main to develop July 29, 2022 17:48
StanfordLin
StanfordLin approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@StanfordLin StanfordLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanfordLin StanfordLin merged commit 0062123 into develop Jul 29, 2022
@StanfordLin StanfordLin deleted the fix-map-bug branch July 29, 2022 18:09
StanfordLin added a commit that referenced this pull request Aug 10, 2022
@StanfordLin
Merge pull request #31 from azra-l/fix-map-bug
9decf44 
Fix map bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanfordLin StanfordLin StanfordLin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azra-l @StanfordLin