Bug: Kael'thas Sunstrider Advisors not scaling

[alca-00]

Current Behaviour

Entering Tempest keep, flying to Kael'thas shows his advisors placed at their unscaled settings.
Thaladred the Darkener begins at 191k hp and it's his full health pool - not a visual error. Kael'thas Sunstrider appears scaled down unlike his allies.

If you begin & reset the fight autobalance scales them properly.
Strangely, if you use .go c 12567 in a fresh TK instance Thaladred attacks you for a brief moment with his stats appearing scaled down, then resets to a non combat state with his stats scaled to their original state (191k hp) and the Kael'thas RP for the encounter finally begins.

Links to advisors for reference
https://wowgaming.altervista.org/aowow/?npc=20060
https://wowgaming.altervista.org/aowow/?npc=20064
https://wowgaming.altervista.org/aowow/?npc=20063
https://wowgaming.altervista.org/aowow/?npc=20062

Expected Behaviour

Advisors should have their health automatically scaled through autobalance before the encounter begins

Steps to reproduce the problem

1. Enter Tempest Keep through the entrance portal or gm teles
2. Visit Kael'thas & compare your AB settings to his advisors starting health

Extra Notes

No response

AutoBalance Debug Commands

Mapstats + Expected Creaturestat

AC rev. hash/commit

AzerothCore rev. 5bfd06ae45ea+ 2023-11-10 19:28:04 +0000 (master branch) (Win64, RelWithDebInfo, Static)

Operating system

Windows 10 x64

Custom changes or Modules

Using Autobalance rev. 02225b4

[kjack9]

I am investigating this. So far I've eliminated one cause of the issue but there is something else going on that I don't understand.

I was trying to save some processing time by not modifying any creature that got respawned in but had already been adjusted. Something about how the advisors are spawned in causes them to be created twice without being removed from the world.

The previous check was adjusting the advisor the first time, but assumed that it had already done what it needed to the second time. Once I removed that check and attempted to re-process him, a different issue popped up.

Something in AC is telling AutoBalance that the creature is dead, so he is being skipped for alterations. I'm sure this has to do with the respawn logic, which uses dead states to force the game to respawn creatures. But as far as why this particular case is causing issues, I don't know yet.

[kjack9]

Figured it out, I think there's a bug in AC. I'll get a PR in to fix it.

[kjack9]

@alca-00

You can test my solution by using this branch of AzerothCore: https://github.com/kjack9/azerothcore-wotlk/tree/fix-force-respawn

You'll also need the version of AutoBalance in this branch: https://github.com/kjack9/mod-autobalance/tree/kjack9/issue172

[alca-00]

First time trying to build a second server alongside my existing one so hopefully I didn't make any mistakes in the process
Using your branch + autobalance with these stock settings

So far I see the advisors still sitting at an unscaled HP despite these multipliers, the rest of the dungeon is scaling appropriately

[kjack9]

So far I see the advisors still sitting at an unscaled HP despite these multipliers, the rest of the dungeon is scaling appropriately

Can you use these zip files just to be 100% sure you're running the modified code, please?

https://github.com/kjack9/azerothcore-wotlk/archive/refs/heads/fix-force-respawn.zip
https://github.com/kjack9/mod-autobalance/archive/refs/heads/kjack9/issue172.zip

Note that you'll need to rename the mod-autobalance-kjack9-issue172 folder to mod-autobalance when you put it in your modules directory.

I was able to perfectly replicate the issue, and those versions 100% fixed it for me. If the bug is still happening for you, I'm not sure what's going on.

[alca-00]

Compiled again, bosses scale automatically. Sorry about that! Must've made a noob mistake, .server info gives me a different acore rev. than the first pic I posted so this one definitely is your intended zip file

[kjack9]

Awesome, glad to hear that fixed it. I'll continue chasing the PR in the azerothcore repo and see if we can get a fix going that will take care of this.

[kjack9]

Sorry for the delay in getting this resolved - still working to find a solution in the AC PR. Hopefully soon.

[AldebaraanMKII]

Idk if this helps, but on AzerothCore rev. b45a3fcac97b 2023-08-13 his advisors are scaling properly. Maybe you can compare both versions to see the difference?

[pangolp]

Idk if this helps, but on AzerothCore rev. b45a3fcac97b 2023-08-13 his advisors are scaling properly. Maybe you can compare both versions to see the difference?

This topic seems abandoned, thanks for returning it. We will see what information there is about it.