-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Kael'thas Sunstrider Advisors not scaling #172
Bug: Kael'thas Sunstrider Advisors not scaling #172
Comments
I am investigating this. So far I've eliminated one cause of the issue but there is something else going on that I don't understand. I was trying to save some processing time by not modifying any creature that got respawned in but had already been adjusted. Something about how the advisors are spawned in causes them to be created twice without being removed from the world. The previous check was adjusting the advisor the first time, but assumed that it had already done what it needed to the second time. Once I removed that check and attempted to re-process him, a different issue popped up. Something in AC is telling AutoBalance that the creature is dead, so he is being skipped for alterations. I'm sure this has to do with the respawn logic, which uses dead states to force the game to respawn creatures. But as far as why this particular case is causing issues, I don't know yet. |
Figured it out, I think there's a bug in AC. I'll get a PR in to fix it. |
You can test my solution by using this branch of AzerothCore: https://github.com/kjack9/azerothcore-wotlk/tree/fix-force-respawn You'll also need the version of AutoBalance in this branch: https://github.com/kjack9/mod-autobalance/tree/kjack9/issue172 |
Can you use these zip files just to be 100% sure you're running the modified code, please? https://github.com/kjack9/azerothcore-wotlk/archive/refs/heads/fix-force-respawn.zip Note that you'll need to rename the I was able to perfectly replicate the issue, and those versions 100% fixed it for me. If the bug is still happening for you, I'm not sure what's going on. |
Compiled again, bosses scale automatically. Sorry about that! Must've made a noob mistake, .server info gives me a different acore rev. than the first pic I posted so this one definitely is your intended zip file |
Awesome, glad to hear that fixed it. I'll continue chasing the PR in the azerothcore repo and see if we can get a fix going that will take care of this. |
Sorry for the delay in getting this resolved - still working to find a solution in the AC PR. Hopefully soon. |
Idk if this helps, but on AzerothCore rev. b45a3fcac97b 2023-08-13 his advisors are scaling properly. Maybe you can compare both versions to see the difference? |
This topic seems abandoned, thanks for returning it. We will see what information there is about it. |
Current Behaviour
Entering Tempest keep, flying to Kael'thas shows his advisors placed at their unscaled settings.
Thaladred the Darkener begins at 191k hp and it's his full health pool - not a visual error. Kael'thas Sunstrider appears scaled down unlike his allies.
If you begin & reset the fight autobalance scales them properly.
Strangely, if you use
.go c 12567
in a fresh TK instance Thaladred attacks you for a brief moment with his stats appearing scaled down, then resets to a non combat state with his stats scaled to their original state (191k hp) and the Kael'thas RP for the encounter finally begins.Links to advisors for reference
https://wowgaming.altervista.org/aowow/?npc=20060
https://wowgaming.altervista.org/aowow/?npc=20064
https://wowgaming.altervista.org/aowow/?npc=20063
https://wowgaming.altervista.org/aowow/?npc=20062
Expected Behaviour
Advisors should have their health automatically scaled through autobalance before the encounter begins
Steps to reproduce the problem
Extra Notes
No response
AutoBalance Debug Commands
Mapstats + Expected Creaturestat
![Wow_aH0GgGp6xu](https://private-user-images.githubusercontent.com/149727824/282179848-bfa3e6d8-29c8-431d-8a24-0c4cfcaf717a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyODE5MjUsIm5iZiI6MTcyNDI4MTYyNSwicGF0aCI6Ii8xNDk3Mjc4MjQvMjgyMTc5ODQ4LWJmYTNlNmQ4LTI5YzgtNDMxZC04YTI0LTBjNGNmY2FmNzE3YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyMVQyMzA3MDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zNDA4ZDRlODEyNDZlYmZiMGY3Mzc2NzBhYWE1MzdiMmMxZmQ3NTVlZDIwMGM0ZjM4NjdjMjY4YTYzMzQ5ZjA2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.7iFbyUkYbg43v8b6xoaSlIyhTn78eHDZrfr7-lGaqMU)
![Wow_XqhtXoUxYc](https://private-user-images.githubusercontent.com/149727824/282181730-3818d589-5873-457d-9ee3-e0ebc96f8f9a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyODE5MjUsIm5iZiI6MTcyNDI4MTYyNSwicGF0aCI6Ii8xNDk3Mjc4MjQvMjgyMTgxNzMwLTM4MThkNTg5LTU4NzMtNDU3ZC05ZWUzLWUwZWJjOTZmOGY5YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyMVQyMzA3MDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00OWZiZDdlNjA2YWFjOWNkYTYwZDFkNmIzNjE2YzY2YTk3OTk0MmU4YmE1NmE2Njc3NTMyOTQxZTc0NjU5M2YxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.KULGofaOIXqe_S48oe7zYVqJags-hadwSdA8aRN79gM)
AC rev. hash/commit
AzerothCore rev. 5bfd06ae45ea+ 2023-11-10 19:28:04 +0000 (master branch) (Win64, RelWithDebInfo, Static)
Operating system
Windows 10 x64
Custom changes or Modules
Using Autobalance rev. 02225b4
The text was updated successfully, but these errors were encountered: