Bug: Vehicle-based Combat is inconsistent

[kjack9]

Current Behaviour

Note: this bug is for after the world modifier PR (#157) is merged into master

Vehicle-based combat is inconsistent at best. Player vehicles are scaled like regular creatures. The target creatures on something like ICC Gunboat are also scaled. Destructible building damage is being scaled using the world damage/healing modifier.

Need to think about what the desired end-state is, keeping in mind that there are both level-adjustments considers and player-count-adjustment considerations.

Expected Behaviour

Perceived difficulty should remain the same between a normal boss and a vehicle-based encounter.

Steps to reproduce the problem

1. Run latest version of mod-autobalance that uses world modifiers
2. Initiate the ICC Gunboat battle or the Ulduar Flame Leviathan pre-show
3. Use .ab creaturestat to note the issues seen in the description above

Extra Notes

Alliance Gunship Cannon (player "vehicle") is being scaled.

Creature's on the gunship are being scaled.

Both player vehicle-to-creature and creature-to-player damage are being scaled.

Creature-to-Skybreaker damage is being scaled.

Ulduar Siege Engine (player vehicle) is being scaled.

Vehicle-to-GameObject (destructible building) damage is being scaled. Vehicle-to-creature damage is not.

Creature-to-Vehicle damage is being scaled. Vehicle-to-Creature damage is being scaled.

AC rev. hash/commit

AzerothCore rev. efbd378d713c+ 2023-10-11 20:11:16 +0000 (master branch) (Unix, RelWithDebInfo, Static)
Connected players: 2. Characters in world: 2.
Connection peak: 4.
Server uptime: 11 hour(s) 29 minute(s) 50 second(s)
Update time diff: 4ms, average: 4ms.
Using SSL version: OpenSSL 3.0.2 15 Mar 2022 (library: OpenSSL 3.0.2 15 Mar 2022)
Using Boost version: 1.74.0
Using CMake version: 3.22.1
Using MySQL version: 80032
Found MySQL Executable: /usr/bin/mysql
Compiled on: Linux 5.15.0-82-generic
Worldserver listening connections on port 8085
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1
MMAPs status: Enabled
maps directory located in /azerothcore/env/dist/data/maps. Total size: 291014951 bytes
vmaps directory located in /azerothcore/env/dist/data/vmaps. Total size: 658130721 bytes
mmaps directory located in /azerothcore/env/dist/data/mmaps. Total size: 2192910844 bytes
Default DBC locale: enUS.
All available DBC locales: enUS zhTW 
Using World DB: ACDB 335.10-dev
Latest LoginDatabase update: 2023_04_24_00.sql
Latest CharacterDatabase update: trasmorg.sql
Latest WorldDatabase update: world.sql
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0
> List enable modules:
- mod-ah-bot
- mod-assistant
- mod-autobalance
- mod-customlogin
- mod-eluna
- mod-guildhouse
- mod-item-level-up
- mod-junk-to-gold
- mod-learnspells
- mod-npc-enchanter
- mod-npc-free-professions
- mod-npc-services
- mod-reagent-bank
- mod-skip-dk-starting-area
- mod-transmog
- mod-weapon-visual
- mod-who-logged

Operating system

Ubuntu 22.04 LTS Server

Custom changes or Modules

Running dev version of mod-autobalance that is set for merge in #157