Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creature Text Editor Issues #3008

Closed
Gultask opened this issue Jun 6, 2024 · 3 comments · Fixed by #3038
Closed

Creature Text Editor Issues #3008

Gultask opened this issue Jun 6, 2024 · 3 comments · Fixed by #3038

Comments

@Gultask
Copy link
Contributor

Gultask commented Jun 6, 2024

There's 2 issues with the creature text editor.

Row Selection

When selecting a row, it seems to select by ID, regardless of GroupID, making it hard to select rows which include more than one group of texts. For example, Nat Pagle (20344) has 23 rows with all unique GroupIDs but with ID all 0, so when selecting one row, it'll be impossible to edit.

Both GroupID and ID are primary keys. and only one row can be edited at a time.

image

Default Values

This one's easier (and more of a suggestion), when creating a new row, some fields should be already entered by default. Although it's not explicit in the table, probability is nearly always 100 and the type should be 12, since that's the most common value.

@FrancescoBorzi
Copy link
Collaborator

@Instantium can you please have a look at this?

@Instantium
Copy link
Contributor

Gultask is correct. Only the ID is used and not the ID and groupID. I can fix this.

@FrancescoBorzi just to check with you:
I am using the MultiRowEditorService but I would need something like the MultiRowComplexKeyEditorService but for a complex secondary key. AFAIK there is no such Service, so I would add one. Ok with you?

I am also on board with adding default values.
Also I will remove creatureID since it is always the same anyway and never shown in other similar pages.

@FrancescoBorzi
Copy link
Collaborator

Gultask is correct. Only the ID is used and not the ID and groupID. I can fix this.

@FrancescoBorzi just to check with you: I am using the MultiRowEditorService but I would need something like the MultiRowComplexKeyEditorService but for a complex secondary key. AFAIK there is no such Service, so I would add one. Ok with you?

I am also on board with adding default values. Also I will remove creatureID since it is always the same anyway and never shown in other similar pages.

@Instantium yes, what you said seems correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants