Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanity check ranges in freeze.py #1686

Merged
merged 2 commits into from
Jul 5, 2024
Merged

sanity check ranges in freeze.py #1686

merged 2 commits into from
Jul 5, 2024

Commits on Jun 7, 2024

  1. sanity check ranges in freeze.py 

    this will catch problems earlier and more clearly.

in my case, it appears that deepspeed zero3 sets layer tensor shapes
to [0], which doesn't play well with automatically inferred ranges.
through a bit of luck, inverting ranges still appears to work correctly.
    @josharian
    josharian committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    31b47a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. simplify chained comparison

    @josharian
    josharian committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a7a864e View commit details
    Browse the repository at this point in the history