Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config validation should warn when full fine tune w load_in_*bit is used #717

Closed
5 tasks done
winglian opened this issue Oct 12, 2023 · 1 comment
Closed
5 tasks done

Config validation should warn when full fine tune w load_in_*bit is used #717

winglian opened this issue Oct 12, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@winglian
Copy link
Collaborator

⚠️ Please check that this feature request hasn't been suggested before.

  • I searched previous Ideas in Discussions didn't find any similar feature requests.
  • I searched previous Issues didn't find any similar feature requests.

🔖 Feature description

full fine tunes in 8/4 bit is not supported, but we don't warn the user

✔️ Solution

add validation to warn

❓ Alternatives

No response

📝 Additional Context

No response

Acknowledgements

  • My issue title is concise, descriptive, and in title casing.
  • I have searched the existing issues to make sure this feature has not been requested yet.
  • I have provided enough information for the maintainers to understand and evaluate this request.
@winglian winglian added enhancement New feature or request good first issue Good for newcomers labels Oct 12, 2023
@NanoCode012 NanoCode012 mentioned this issue Oct 22, 2023
Merged
@NanoCode012
Copy link
Collaborator

Solved in #770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@winglian @NanoCode012