Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): zkevm-keccak test should have first_pass = SKIP_FIRST_PASS #96

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix(test): zkevm-keccak test should have first_pass = SKIP_FIRST_PASS #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion hashes/zkevm-keccak/src/keccak_packed_multi/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ use crate::halo2_proofs::{
Blake2bRead, Blake2bWrite, Challenge255, TranscriptReadBuffer, TranscriptWriterBuffer,
},
};
use halo2_base::SKIP_FIRST_PASS;
use rand_core::OsRng;

/// KeccakCircuit
Expand Down Expand Up @@ -52,7 +53,7 @@ impl<F: Field> Circuit<F> for KeccakCircuit<F> {
) -> Result<(), Error> {
config.load_aux_tables(&mut layouter)?;
let mut challenge = layouter.get_challenge(config.challenge);
let mut first_pass = true;
let mut first_pass = SKIP_FIRST_PASS;
layouter.assign_region(
|| "keccak circuit",
|mut region| {
Expand All @@ -75,6 +76,7 @@ impl<F: Field> Circuit<F> for KeccakCircuit<F> {
challenge,
squeeze_digests,
);
println!("finished keccak circuit");
Ok(())
},
)?;
Expand Down Expand Up @@ -119,6 +121,7 @@ fn packed_multi_keccak_simple() {
verify::<Fr>(k, inputs, true);
}

/// Cmdline: KECCAK_DEGREE=14 RUST_LOG=info cargo test -- --nocapture packed_multi_keccak_prover
#[test]
fn packed_multi_keccak_prover() {
let _ = env_logger::builder().is_test(true).try_init();
Expand Down