Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add util and fix warning when compiling with halo2-pse feature mode #253

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

zemse
Copy link
Contributor

@zemse zemse commented Jan 24, 2024

  • add get_lower_128 with impl to ScalarField trait

@zemse zemse changed the base branch from community-edition to main January 24, 2024 07:10
@jonathanpwang
Copy link
Contributor

Please make PRs to community-edition

@zemse zemse changed the base branch from main to community-edition January 29, 2024 05:32
@zemse zemse changed the title add get_lower_128 with impl to ScalarField trait add util and fix warning when compiling with halo2-pse feature mode Feb 13, 2024
@zemse
Copy link
Contributor Author

zemse commented Feb 13, 2024

I have changed the branch. Can you pls review the PR?

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpwang jonathanpwang merged commit a2a548b into axiom-crypto:community-edition Jul 26, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants