Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : num_limbs_log2_ceil #236

Merged
merged 3 commits into from
Feb 3, 2024
Merged

fix : num_limbs_log2_ceil #236

merged 3 commits into from
Feb 3, 2024

Conversation

enricobottazzi
Copy link
Contributor

No description provided.

@jonathanpwang
Copy link
Contributor

Could you explain this PR? num_limbs_log2_ceil is not a function I believe.
bit_length can be 1 greater than log2_ceil, if that is the fix?

@enricobottazzi
Copy link
Contributor Author

You're right. I meant to use log2_ceil() util instead.

As you mentioned, the fix relates to the possible discrepancy between bit_length and log2_ceil.

If this makes sense to you, I can go ahead and fix it.

@jonathanpwang
Copy link
Contributor

Ok I checked and I think using log2_ceil from util would be correct. Please make the fix

@jonathanpwang jonathanpwang enabled auto-merge (rebase) February 3, 2024 06:02
jonathanpwang
jonathanpwang approved these changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathanpwang jonathanpwang merged commit 86f676e into axiom-crypto:community-edition Feb 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enricobottazzi @jonathanpwang