Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] derive Hash for BaseCircuitParams #172

Merged
merged 1 commit into from
Sep 29, 2023
Merged

[chore] derive Hash for BaseCircuitParams #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion halo2-base/src/gates/circuit/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ pub mod builder;

/// A struct defining the configuration parameters for a halo2-base circuit
/// - this is used to configure [BaseConfig].
#[derive(Clone, Default, Debug, Serialize, Deserialize)]
#[derive(Clone, Default, Debug, Hash, Serialize, Deserialize)]
pub struct BaseCircuitParams {
// Keeping FlexGateConfigParams expanded for backwards compatibility
/// Specifies the number of rows in the circuit to be 2<sup>k</sup>
Expand Down
2 changes: 1 addition & 1 deletion halo2-base/src/gates/flex_gate/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,7 @@ pub trait GateInstructions<F: ScalarField> {

/// Constrains and returns little-endian bit vector representation of `a`.
///
/// Assumes `range_bits <= number of bits in a`.
/// Assumes `range_bits >= bit_length(a)`.
/// * `a`: [QuantumCell] of the value to convert
/// * `range_bits`: range of bits needed to represent `a`
fn num_to_bits(
Expand Down
Loading