Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] max_rows in BaseCircuitBuilder in Keccak Leaf Circuit #152

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[fix] max_rows in BaseCircuitBuilder in Keccak Leaf Circuit #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hashes/zkevm/src/keccak/coprocessor/circuit/leaf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,12 @@ impl<F: Field> Circuit<F> for KeccakCoprocessorLeafCircuit<F> {

/// Configures a new circuit using [`BaseConfigParams`]
fn configure_with_params(meta: &mut ConstraintSystem<F>, params: Self::Params) -> Self::Config {
let keccak_circuit_config = KeccakCircuitConfig::new(meta, params.keccak_circuit_params);
let base_circuit_params = params.base_circuit_params;
// BaseCircuitBuilder::configure_with_params must be called in the end in order to get the correct
// unusable_rows.
let base_circuit_config =
BaseCircuitBuilder::configure_with_params(meta, base_circuit_params.clone());
let keccak_circuit_config = KeccakCircuitConfig::new(meta, params.keccak_circuit_params);
Self::Config { base_circuit_config, keccak_circuit_config }
}

Expand Down
Loading