Skip to content

Commit

Permalink
[fix] max_rows in BaseCircuitBuilder in Keccak Leaf Circuit (#152)
Browse files Browse the repository at this point in the history
Fix max_rows in BaseCircuitBuilder inside Keccak Vanilla
  • Loading branch information
nyunyunyunyu authored and jonathanpwang committed Sep 18, 2023
1 parent 1bf36b1 commit 12f190a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion hashes/zkevm/src/keccak/coprocessor/circuit/leaf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,12 @@ impl<F: Field> Circuit<F> for KeccakCoprocessorLeafCircuit<F> {

/// Configures a new circuit using [`BaseConfigParams`]
fn configure_with_params(meta: &mut ConstraintSystem<F>, params: Self::Params) -> Self::Config {
let keccak_circuit_config = KeccakCircuitConfig::new(meta, params.keccak_circuit_params);
let base_circuit_params = params.base_circuit_params;
// BaseCircuitBuilder::configure_with_params must be called in the end in order to get the correct
// unusable_rows.
let base_circuit_config =
BaseCircuitBuilder::configure_with_params(meta, base_circuit_params.clone());
let keccak_circuit_config = KeccakCircuitConfig::new(meta, params.keccak_circuit_params);
Self::Config { base_circuit_config, keccak_circuit_config }
}

Expand Down

0 comments on commit 12f190a

Please sign in to comment.