Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotations to map a zTOC to its corresponding layer #12

Closed
wmesard opened this issue Aug 16, 2022 · 0 comments · Fixed by #23
Closed

Use annotations to map a zTOC to its corresponding layer #12

wmesard opened this issue Aug 16, 2022 · 0 comments · Fixed by #23
Assignees

Comments

@wmesard
Copy link
Contributor

wmesard commented Aug 16, 2022

Is your feature request related to a problem? Please describe.

For very small layers, it’s not worth creating a zTOC; it’s more performant to just pull the layer at launch time, and untar it. Hence, the soci create --min-layer-size option.

The problem is that today we use null values in the descriptors array to represent these "missing" zTOCs.
In other words, soci.descriptors[i] always corresponds to image.layers[i]. The problem is that ORAS doesn't like that.
This wasn't necessarily a deal breaker, since we will soon be moving to Reference Types. But, they don't really like it either.

Describe the solution you'd like

Rather than fight this fight, let's just go with the annotation based approach. That is, each entry in the descriptors array can have an annotation containing the digest of the corresponding layer.

@wmesard wmesard assigned wmesard and vkuzniet and unassigned wmesard Aug 17, 2022
@wmesard wmesard linked a pull request Aug 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants