Smithy Language Server integration #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
reviewed
Apr 29, 2022
* Bundle extension with webpack * Run tests against webpacked extension
srchase
force-pushed
the
lang-server-integration
branch
from
240c792
to
19b1888
Compare
srchase
changed the title
JordonPhillips
approved these changes
Jun 14, 2022
| `npm install && npm run install-plugin` | ||
| * Open VS Code and add a `smithy-build.json` file to the root of your project, |
There was a problem hiding this comment.
Is this necessary? What happens when I look at a detached model file?
There was a problem hiding this comment.
Not in that case. Only if you have dependencies that need loaded. I'll update that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the extension to begin using the Smithy Language Server.
The contents of
src/extension.tsandsrc/coursier/are borrowed from Disney's Smithy VSCode Extension, which uses Coursier to bootstrap the Smithy Language Server and resolve model dependencies specified in a workspace'ssmithy-build.json.The PR also adds integration tests which check the extension launches the Smithy Language Server successfully, resolves model dependencies, and uses the Smithy Language Server to provide diagnostics. For now, the integration tests do not un on CI since the Smithy Language Server is not yet being published.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.