Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag NuGet release commits #114

Open
GabrielHare opened this issue May 6, 2023 · 2 comments
Open

Tag NuGet release commits #114

GabrielHare opened this issue May 6, 2023 · 2 comments
Labels
documentation This is an issue with documentation. feature-request A feature should be added or improved. module/cognito-ext p3 This is a minor priority issue queued

Comments

@GabrielHare
Copy link
Contributor

Describe the issue

The latest release of this project on NuGet is 2.4.0
https://www.nuget.org/packages/Amazon.Extensions.CognitoAuthentication/2.4.0

Most of the other versions on NuGet are also not tagged.

Presently there is no tag identifying the commit for this release. Based on commit times I would assume the release commit is on the current latest on master branch.
4e9f2fa

Links

No links - this is a an issue with tags, not document files.

@GabrielHare GabrielHare added documentation This is an issue with documentation. needs-triage This issue or PR still needs to be triaged. labels May 6, 2023
@ashishdhingra
Copy link
Contributor

@GabrielHare Thanks for submitting the issue. For high level libraries like Cognito, we do not tag release commits. But we do update changelog for each release. If you notice the size of changelog, we release small amount of fixes in each version, as compared to AWS SDK for .NET releases. I can discuss with the team, but not sure if we would decide to maintain release tags.

Thanks,
Ashish

@ashishdhingra ashishdhingra added needs-review and removed needs-triage This issue or PR still needs to be triaged. labels May 8, 2023
@GabrielHare
Copy link
Contributor Author

Thank you - tracking the change log will provide me with commit hashes to use for version locking, at least for the most recent versions.

Reasons why I would like the project have release tags.
(1) This is how I (and probably others) would expect to identify release commits
(2) In the case of a scripted git clone (or simply written instructions), the checking out a tag is clearer than checking out a hash

@ashishdhingra ashishdhingra added p3 This is a minor priority issue feature-request A feature should be added or improved. queued and removed needs-review labels May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is an issue with documentation. feature-request A feature should be added or improved. module/cognito-ext p3 This is a minor priority issue queued
Projects
None yet
Development

No branches or pull requests

2 participants