Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): add pagination stopOnSameToken option #3524

Merged
merged 3 commits into from
Apr 25, 2022
Merged

feat(types): add pagination stopOnSameToken option #3524

merged 3 commits into from
Apr 25, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Apr 8, 2022

Issue

#3490

Description

Add an option to stop paginators on receiving the same token (indicates tail has been reached).

Testing

tested in the smithy change

Additional context

@kuhe kuhe requested a review from a team as a code owner April 8, 2022 19:00
@kuhe kuhe mentioned this pull request Apr 8, 2022
Merged
@AllanZhengYP AllanZhengYP self-requested a review April 12, 2022 17:02
@AllanZhengYP
Copy link
Contributor

@kuhe It looks good. Because this change also updates the generated client's code, can you re-generate the clients? Regarding the CodeBuild failure, you need to merge the upstream PR before restart the CodeBuild.

@kuhe kuhe force-pushed the paginator branch 2 times, most recently from 300fed9 to baff6f1 Compare April 13, 2022 00:24
@kuhe
Copy link
Contributor Author

kuhe commented Apr 13, 2022 •
edited
Loading

@AllanZhengYP thanks for the doc update.

I've pushed the client changes. Something I'd like to PR in the future is a createPaginator higher order function to reduce the code size spent on these paginators.

@AllanZhengYP
Copy link
Contributor

@kuhe I like the idea of more abstractions. Though I have some questions with the function input. Can you follow up on this in a separate issue / internal doc?

AllanZhengYP
AllanZhengYP previously approved these changes Apr 13, 2022
View reviewed changes
@kuhe kuhe requested a review from AllanZhengYP April 21, 2022 17:52
AllanZhengYP
AllanZhengYP previously approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve it, please regenerate the paginators after today's release before merging it.

@kuhe kuhe merged commit 9bf73e8 into aws:main Apr 25, 2022
@kuhe kuhe deleted the paginator branch April 25, 2022 21:13
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees

@AllanZhengYP AllanZhengYP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @AllanZhengYP