Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): add retryModeProvider in runtimeConfig #2440

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 28, 2021

Issue

Internal JS-2635

Description

Adds retryModeProvider in runtimeConfig for clients.
This provider is going to be used in middleware-retry to call adaptive retry strategy if provided in the environment or shared ini configurations.

Testing

Testing will be done when middleware-retry is updated.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr

This comment has been minimized.

@trivikr trivikr force-pushed the clients-retryModeProvider branch from 7097d4f to 66a6f3d Compare May 28, 2021 13:40
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@1c4473c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2440   +/-   ##
=======================================
  Coverage        ?   59.08%           
=======================================
  Files           ?      490           
  Lines           ?    26204           
  Branches        ?     6224           
=======================================
  Hits            ?    15482           
  Misses          ?    10722           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4473c...00d61e9. Read the comment docs.

@alexforsyth
Copy link
Contributor

Can you link the smithy typescript PR?

@trivikr
Copy link
Member Author

trivikr commented May 28, 2021

Can you link the smithy typescript PR?

There is no equivalent PR in smithy-typescript, as retryModeProvider is specific to AWS clients.
The codegen changes are in AddAwsRuntimeConfig.java

@trivikr trivikr merged commit fc0a5da into aws:main Jun 1, 2021
@trivikr trivikr deleted the clients-retryModeProvider branch June 1, 2021 20:06
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants