Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use ts-jest for running jest tests #2088

Merged
merged 15 commits into from
Mar 19, 2021
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 25, 2021

Issue

Fixes: #1032

Description

Runs all jest tests using ts-jest. This removes the need of transpiling *.spec.ts files allowing developers to build source just once, and run tests without transpling.

Caveat: The build command is removed from pretest for individual packages. Developers will have to explicitly run build instead of pretest before running tests.

Testing

Verified that jest tests are successfully run after the build is successful.

$ yarn test:all

$ yarn test:integration

# in packages/abort-controller
$ yarn test

# in lib/lib-storage
$ yarn test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore(deps-dev): add ts-jest feat: use ts-jest for running jest tests Feb 25, 2021
@codecov-io
Copy link

codecov-io commented Feb 25, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@105c9b7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5000459 differs from pull request most recent head e548c7b. Consider uploading reports for the commit e548c7b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2088   +/-   ##
=======================================
  Coverage        ?   78.83%           
=======================================
  Files           ?      377           
  Lines           ?    16095           
  Branches        ?     3489           
=======================================
  Hits            ?    12688           
  Misses          ?     3407           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105c9b7...e548c7b. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 6c9b9c8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some discussion offline. LGTM!

@trivikr trivikr merged commit 456002c into aws:main Mar 19, 2021
@trivikr trivikr deleted the move-ts-jest branch March 19, 2021 00:44
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this pull request Mar 24, 2021
@github-actions
Copy link

github-actions bot commented Apr 3, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ts-jest so that test files can be run without transpiling
4 participants