feat: add code linting and prettify #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexforsyth
commented
Jul 9, 2020
.prettierrc.js
Outdated
| @@ -0,0 +1,7 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
This file is added by mistake, removed here: 716b289
Codecov Report
@@ Coverage Diff @@
## master #1350 +/- ##
==========================================
+ Coverage 79.00% 79.02% +0.02%
==========================================
Files 287 287
Lines 11112 11123 +11
Branches 2350 2350
==========================================
+ Hits 8779 8790 +11
Misses 2333 2333
Continue to review full report at Codecov.
|
trivikr
requested changes
Jul 10, 2020
This reverts commit a525b24.
trivikr
requested changes
Jul 10, 2020
trivikr
approved these changes
Jul 10, 2020
AllanZhengYP
approved these changes
Jul 10, 2020
AllanZhengYP
approved these changes
Jul 10, 2020
trivikr
added a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Jul 15, 2020
trivikr
added a commit
that referenced
this pull request
Jul 16, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: We don't have a linter or prettify function implemented that will easily format your code for you
Description of changes:
Added linting with eslint to the codebase. This runs at the root and takes ~5sec.
yarn run lint
real 0m4.294s
user 0m5.053s
sys 0m0.560s
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.