fix(cloudfront): requirement of domainNames prevents moving a domain name between distributions

[Tietew]

Issue # (if applicable)

Closes #29960.

Reason for this change

When I want to move a domain name from a distribution to another distribution,
I must create a distribution with a certificate associated but no domain names.

Description of changes

Re-submit of previous #29329.
Removed the validation that domainNames must not be blank when a certificate is associated.

Description of how you validated changes

Updated a unit test to allow absent domainNames when a certificate is associated.

See AWS Documentation for details: Using custom URLs by adding alternate domain names (CNAMEs) > Moving an alternate domain name to a different distribution
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/CNAMEs.html#alternate-domain-names-move

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[Tietew]

Exemption Request

There are no integ tests for a distribution with certificate.

[gracelu0]

Exemption Request

There are no integ tests for a distribution with certificate.

Hi @Tietew , are there any issues preventing us from adding such an integ test? If not it would be great if you could add one as part of this PR.

[Tietew]

@gracelu0 Thank you for your comment.

Integ test for this PR needs an issued public ACM certificate, which requires a reachable DNS zone (Route53 public hosted zone).
I can run tests using my private domain, but others cannot reproduce it with the same domain.
They seem a reason why integ tests do not exist currently for distributions with certificate.
Unit tests may cover whether the generated template is correct.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[gracelu0]

Reading the docs, I see that moving the domain name requires calling the associate-alias CLI command. So this change just allows the user to create a target distribution but they would still need to call associate-alias correct? I think it would be helpful to include an example of how someone would do this in CDK in the README.

[Tietew]

Yes. We should call associate-alias cli command manually.
I will add the instructions.

[Tietew]

I've added a new section to the README.
Thanks for your suggestion!

Pull request has been modified.

[gracelu0]

LGTM, thank you for contributing!

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 02d3c37
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.