Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): add missing types for webhook filters #30064

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

msambol
Copy link
Contributor

@msambol msambol commented May 5, 2024

The full list is found here.

Closes #30062.

@aws-cdk-automation aws-cdk-automation requested a review from a team May 5, 2024 21:59
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels May 5, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@msambol
Copy link
Contributor Author

msambol commented May 6, 2024

Exemption Request: I need a GitHub access token to update the integration test: Could not find access token for server type github. I think it's OK with no integration test update as I'm only adding enum values.

Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an integ test for these enums? The integ tests helps prevent regressions.

@msambol
Copy link
Contributor Author

msambol commented May 6, 2024

Could you add an integ test for these enums? The integ tests helps prevent regressions.

See my exemption request above. I think I need an access token? Happy to, but CDK core team might need to run it?

@msambol
Copy link
Contributor Author

msambol commented May 9, 2024

@comcalvi The webhooks are only available on GitHub and BitBucket. I looked at doing an integration test with CodeCommit, but not possible here. Let me know how you want to proceed.

@aseppala
Copy link

fyi @msambol & @comcalvi: I opened #30204 that extends this PR and adds the requested integration test. Please have a look.

@comcalvi
Copy link
Contributor

If the only integration test we can add is one that can't be deployed reliably, then I think it's safe to skip the integ test for this one. Thanks both, I think we can leave the integ test off of this one.

@msambol
Copy link
Contributor Author

msambol commented May 21, 2024

@comcalvi changes made as requested 👍🏼

@msambol
Copy link
Contributor Author

msambol commented May 28, 2024

@comcalvi gentle nudge 😄

@msambol
Copy link
Contributor Author

msambol commented Jun 7, 2024

@comcalvi Do I need to do something further to push this through?

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@msambol
Copy link
Contributor Author

msambol commented Jun 11, 2024

@comcalvi Could we push this one through before it gets closed?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f1592c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@comcalvi comcalvi added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jun 11, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 11, 2024 15:29

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Jun 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(codebuild): Add support new newly introduced event filter
5 participants