Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): RDS for SQL Server 16 without a specific minor version #28615

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Jan 8, 2024

This PR supports version 16 for RDS for SQL Server without a specific minor version.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jan 8, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 8, 2024 15:01
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@go-to-k
Copy link
Contributor Author

go-to-k commented Jan 8, 2024

Exemption Request: This PR just adds a version.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 8, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c44740c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 8, 2024
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@go-to-k we can continue to add any random version specification as a static property, but to what end? Why can't users who need this specific configuration just use the of API to create it themselves? Is there a large use case for this particular one that makes the syntactic sugar useful?

@go-to-k
Copy link
Contributor Author

go-to-k commented Jan 9, 2024

@kaizencc
I think it is also true that users are using them because we contributors have been kind enough to add these so far, rather than because there are specific benefits or use cases.

Of course, one use of this syntactic sugar would be to be able to specify it easily by simple input or selection by completion in an editor. However, I honestly believe that if this is not there, users will be able to use of to deal with it. Maybe we could stop these updates and have the existing minor version designations be labeled @deprecated and have them use of instead so that users don't expect these updates, or at most just provide static methods for the major versions only. What do you think?

(But I also do think that one way to do it is to say that we'll continue to follow the minor version as we have in the past.)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 10851d8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Jan 9, 2024
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@go-to-k I see that we have similar versions for 15 and 14 with no specific minor version, so I think we should provide the same support for 16. I know you have been very gracious in adding new versions as they come, but it is also the antithesis of what cdk is about, which is that you can unlock whatever you want via this enum-like class. It's exceedingly simple to specify your own version with of, my hope is that people go down that route rather than wait for your manual updates. But maybe thats wishful thinking.

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 9, 2024 15:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 9, 2024
Copy link
Contributor

mergify bot commented Jan 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 382d261 into aws:main Jan 9, 2024
23 of 26 checks passed
@go-to-k
Copy link
Contributor Author

go-to-k commented Jan 9, 2024

@kaizencc Yes, I really feel the same way. I wish too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants