feat(globalaccelerator): add support for ip addresses and type #28055

msambol · 2023-11-17T20:08:09Z

Closes #28051, #28209.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

werebear73-tritelph · 2023-11-20T15:24:49Z

Thank you for the work on this so far.

go-to-k

Thanks for this PR! I commented some points.

packages/aws-cdk-lib/aws-globalaccelerator/lib/accelerator.ts

packages/aws-cdk-lib/awslint.json

packages/aws-cdk-lib/aws-globalaccelerator/lib/accelerator.ts

msambol · 2023-11-25T17:17:41Z

@go-to-k updated per your feedback. Thanks!

go-to-k

Thanks for the update!

I have commented on some adjustments, please take a look.

packages/aws-cdk-lib/aws-globalaccelerator/lib/accelerator.ts

...g/framework-integ/test/aws-globalaccelerator/test/integ.globalaccelerator-ip-address-type.ts

msambol · 2023-11-29T13:31:47Z

Thanks for the update!

I have commented on some adjustments, please take a look.

Updated—thanks!

packages/aws-cdk-lib/aws-globalaccelerator/lib/accelerator.ts

aws-cdk-automation · 2023-12-03T00:10:34Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

werebear73-tritelph · 2023-12-03T16:38:58Z

Is this ready? I'm not been part of a issue and PR here. How long does it usually take for one to get deployed into production?

go-to-k · 2023-12-06T08:36:51Z

@werebear73-tritelph

There will be a maintainer review after this. I don't know when it will be merged, as it is also up to the maintainer.

sumupitchayan · 2023-12-20T16:24:37Z

packages/aws-cdk-lib/awslint.json

+    "from-method:aws-cdk-lib.aws_apigatewayv2.WebSocketRoute",
+    "props-default-doc:aws-cdk-lib.aws_globalaccelerator.AcceleratorAttributes.dualStackDnsName",
+    "props-default-doc:aws-cdk-lib.aws_globalaccelerator.AcceleratorAttributes.ipv4Addresses",
+    "props-default-doc:aws-cdk-lib.aws_globalaccelerator.AcceleratorAttributes.ipv6Addresses"


@msambol why were these added to awslint.json?

I get a linter error if they're not in this file.

The linter error happens when there is no@default value specified for the props.

Please include:

/** * @default <value> */

in the code comment for your props values and remove the changes to awslint.

@sumupitchayan Pinged you on Slack. These are for imports, I think they'd all be undefined ?

…type

mergify · 2023-12-21T21:41:31Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2023-12-21T21:45:05Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2023-12-21T22:24:46Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: bba7c7d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2023-12-21T22:25:08Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…8055) Closes aws#28051, aws#28209. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Nov 17, 2023

aws-cdk-automation requested a review from a team November 17, 2023 20:08

github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Nov 17, 2023

msambol changed the title ~~feat(globalaccelerator): add support for ip addresses and ip address …~~ feat(globalaccelerator): add support for ip addresses and type Nov 17, 2023

msambol force-pushed the gh-28051 branch from 82364ce to 953a098 Compare November 17, 2023 22:16

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 20, 2023

go-to-k suggested changes Nov 21, 2023

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 21, 2023

go-to-k suggested changes Nov 21, 2023

View reviewed changes

packages/aws-cdk-lib/aws-globalaccelerator/lib/accelerator.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-globalaccelerator/lib/accelerator.ts Outdated Show resolved Hide resolved

go-to-k reviewed Nov 21, 2023

View reviewed changes

packages/aws-cdk-lib/aws-globalaccelerator/lib/accelerator.ts Outdated Show resolved Hide resolved

go-to-k reviewed Nov 21, 2023

View reviewed changes

packages/aws-cdk-lib/aws-globalaccelerator/lib/accelerator.ts Outdated Show resolved Hide resolved

msambol force-pushed the gh-28051 branch 2 times, most recently from b69f399 to 25b3969 Compare November 25, 2023 13:18

go-to-k suggested changes Nov 29, 2023

View reviewed changes

msambol force-pushed the gh-28051 branch from 9202cb5 to 7c7fa54 Compare November 29, 2023 13:00

go-to-k reviewed Nov 29, 2023

View reviewed changes

packages/aws-cdk-lib/aws-globalaccelerator/lib/accelerator.ts Show resolved Hide resolved

msambol mentioned this pull request Dec 1, 2023

AWS::GlobalAccelerator: Add the ability to set the BYOIP IP Addresses for the Global Accelerator. #28209

Closed

2 tasks

github-actions bot mentioned this pull request Dec 1, 2023

Monthly PR metrics report - November 2023 #28212

Closed

go-to-k approved these changes Dec 6, 2023

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 6, 2023

sumupitchayan reviewed Dec 20, 2023

View reviewed changes

feat(globalaccelerator): add support for ip addresses and ip address …

385c26e

…type

msambol added 18 commits December 20, 2023 16:59

new test

cb2e1eb

remove from lint

d8bfb5c

add back lint

b1a6069

Trigger Build

f14409a

add the right linting

d31b452

Trigger Build

e4d86f1

fix int tests after fresh build

232d903

doc fixes

bb838da

change to enum

9484919

fix readme

4e6c426

fix

aeaf102

add feedback from k.goto

6ba2dfc

add ipaddresses validation

d66ca14

some are optional

d133a7c

lint out optional attributes

e2d929e

oops

70d8b4f

another round of feedback from go-to-k

12c828b

Add defaults, remove from awslint.json

f577d64

msambol force-pushed the gh-28051 branch from 1fa57b4 to f577d64 Compare December 20, 2023 23:02

sumupitchayan approved these changes Dec 21, 2023

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 21, 2023

Merge branch 'main' into awsgh-28051

bba7c7d

mergify bot merged commit 943abe8 into aws:main Dec 21, 2023
9 checks passed

msambol deleted the gh-28051 branch December 22, 2023 02:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(globalaccelerator): add support for ip addresses and type #28055

feat(globalaccelerator): add support for ip addresses and type #28055

msambol commented Nov 17, 2023 •

edited

Loading

werebear73-tritelph commented Nov 20, 2023

go-to-k left a comment

msambol commented Nov 25, 2023

go-to-k left a comment

msambol commented Nov 29, 2023

aws-cdk-automation commented Dec 3, 2023

werebear73-tritelph commented Dec 3, 2023

go-to-k commented Dec 6, 2023

sumupitchayan Dec 20, 2023

msambol Dec 20, 2023

sumupitchayan Dec 20, 2023

msambol Dec 20, 2023

msambol Dec 21, 2023

mergify bot commented Dec 21, 2023

mergify bot commented Dec 21, 2023

aws-cdk-automation commented Dec 21, 2023

mergify bot commented Dec 21, 2023

feat(globalaccelerator): add support for ip addresses and type #28055

feat(globalaccelerator): add support for ip addresses and type #28055

Conversation

msambol commented Nov 17, 2023 • edited Loading

werebear73-tritelph commented Nov 20, 2023

go-to-k left a comment

Choose a reason for hiding this comment

msambol commented Nov 25, 2023

go-to-k left a comment

Choose a reason for hiding this comment

msambol commented Nov 29, 2023

aws-cdk-automation commented Dec 3, 2023

werebear73-tritelph commented Dec 3, 2023

go-to-k commented Dec 6, 2023

sumupitchayan Dec 20, 2023

Choose a reason for hiding this comment

msambol Dec 20, 2023

Choose a reason for hiding this comment

sumupitchayan Dec 20, 2023

Choose a reason for hiding this comment

msambol Dec 20, 2023

Choose a reason for hiding this comment

msambol Dec 21, 2023

Choose a reason for hiding this comment

mergify bot commented Dec 21, 2023

mergify bot commented Dec 21, 2023

aws-cdk-automation commented Dec 21, 2023

AWS CodeBuild CI Report

mergify bot commented Dec 21, 2023

msambol commented Nov 17, 2023 •

edited

Loading