fix(integ-runner): fails with "no such file or directory, open 'node_modules/@aws-cdk/integ-runner/lib/workers/db.json.gz'" #27983
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
mrgrain
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
| @@ -1,6 +1,6 @@ | |||
| import * as path from 'path'; | |||
| import { AssemblyManifest, Manifest, ArtifactType, AwsCloudFormationStackProperties, ArtifactManifest, MetadataEntry, AssetManifestProperties, ArtifactMetadataEntryType, ContainerImageAssetMetadataEntry, FileAssetMetadataEntry } from '@aws-cdk/cloud-assembly-schema'; | |||
| import { AssetManifest, FileManifestEntry, DockerImageManifestEntry } from 'cdk-assets'; | |||
| import { AssetManifest, FileManifestEntry, DockerImageManifestEntry } from 'cdk-assets/lib/asset-manifest'; | |||
There was a problem hiding this comment.
It's ugly. But since it's a monorepo we can do it!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mergify
bot
deleted the
mrgrain/fix/integ-runner-fails-to-load-database
branch
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@mrgrain The cli-lib-alpha is still broken for the same reason.
|
|
Thanks! I know why. Looking into it when I'm back at work next week. |
|
@mrgrain let me know if I can help. This issue is a blocker for us. Thank you! |
|
I have the fix ready. Currently making sure this won't happen again. Unfortunately due to re:Invent it won't be released until next week. |
|
Ouch. Which old version of aws cdk is not affected by the bug? We can think of using an older version or a nightly build (if it's possible). |
|
v2.106.0 should be the one that introduced the issue, so anything before that should still work. There isn't anything that's strictly forcing you to keep We don't have nightly builds at the moment. If you want to hack it, this package contains a |
|
Ok, thank you. Hacking is fine for now since we're just developing the solution, ty. 👍 |
…e_modules/@aws-cdk/integ-runner/lib/workers/db.json.gz'" (#28199) After #27813 the `deploy` action was broken with the above error. This is effectively the same as #27983 . To ensure these kind of issues are not slipping through again, the PR is adding a basic testing harness for `cli-lib` to `@aws-cdk-testing/cli-integtests`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
@AntonioAngelino Patched and put some integration tests in place that actually use the bundled code. Should be shipping tomorrow. |
|
Thank you, @mrgrain ! |
…e_modules/@aws-cdk/integ-runner/lib/workers/db.json.gz'" (aws#28199) After aws#27813 the `deploy` action was broken with the above error. This is effectively the same as aws#27983 . To ensure these kind of issues are not slipping through again, the PR is adding a basic testing harness for `cli-lib` to `@aws-cdk-testing/cli-integtests`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Mark the
@aws-cdk/aws-service-specas external, because it cannot be bundled.Changes an import from
cdk-assetsto be more specific, so we don't bundle the whole ofaws-sdkanymore.This reduced the worker entrypoint size from 70MB -> 1.5MB
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license