Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integ-runner): update workflow error message is inaccurate #27924

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 10, 2023

The previously printed command doesn't actual work.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The previously printed command doesn't actual work.
@aws-cdk-automation aws-cdk-automation requested a review from a team November 10, 2023 11:54
@github-actions github-actions bot added the p2 label Nov 10, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 10, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 10, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 10, 2023 11:58

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 10, 2023
Copy link

@k-chainalysis k-chainalysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to clarify in the README that the file containing IntegTest must be checked into git.

Copy link

@k-chainalysis k-chainalysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e4d33d2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 844cd6f into main Nov 10, 2023
13 checks passed
@mergify mergify bot deleted the mrgrain/chore/integ-runner-better-error branch November 10, 2023 14:10
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 10, 2023
mikewrighton pushed a commit that referenced this pull request Nov 13, 2023
The previously printed command doesn't actual work.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants