Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integ-tests): DeployAssert should be private #20466

Merged
merged 6 commits into from
May 23, 2022
Merged

fix(integ-tests): DeployAssert should be private #20466

merged 6 commits into from
May 23, 2022

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented May 23, 2022

The DeployAssert construct is really an implementation detail that is
only used when making assertions as part of integration tests. This PR
makes the construct private and creates a public interface
(IDeployAssert).

This PR also:

  • Removes the scope swap since we no longer need to pass around
    DeployAssert.
  • Removes some unused code (ResultsCollector).

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

corymhall and others added 3 commits May 17, 2022 17:52
The `DeployAssert` construct is really an implementation detail that is
only used when making assertions as part of integration tests. This PR
makes the construct private and creates a public interface
(`IDeployAssert`).

This PR also:

- Removes the scope swap since we no longer need to pass around
`DeployAssert`.
- Removes some unused code (ResultsCollector).
@gitpod-io
Copy link

gitpod-io bot commented May 23, 2022

@github-actions github-actions bot added the p2 label May 23, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team May 23, 2022 12:46
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 23, 2022
@corymhall corymhall requested a review from rix0rrr May 23, 2022 14:57
assert.assert(

const integ = new IntegTest(app, 'Integ', { testCases: [stack] });
integ.deployAssert.expect(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like it.

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label May 23, 2022
@corymhall corymhall removed the pr/do-not-merge This PR should not be merged at this time. label May 23, 2022
@mergify
Copy link
Contributor

mergify bot commented May 23, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 7303172
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0f52813 into aws:master May 23, 2022
@mergify
Copy link
Contributor

mergify bot commented May 23, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr added the effort/medium Medium work item – several days of effort label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants