Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbindVideoElement API does not remove MediaStream #1076

Open
p-foucht opened this issue Feb 19, 2021 · 1 comment
Open

unbindVideoElement API does not remove MediaStream #1076

p-foucht opened this issue Feb 19, 2021 · 1 comment
Labels
feature-request New feature or request video Issues related to quality of the video stream - blurry, jerky, freezes, black screens or unable to s

Comments

@p-foucht
Copy link
Contributor

Describe the bug
The unbindVideoElement API does not remove the MediaStream from the video element. Since the bindVideoElement is responsible for attaching the stream, the unbindVideoElement call should remove it.

This is needed when moving video elements around the DOM. Currently, unbinding and rebinding the same VideoTile will create two videos playing the same stream.

Workaround
You can workaround this by manually remove the srcObject of the video element, or disposing of the video element altogether.

const videoEl = document.querySelector(...);
audioVideo.unbindVideoElement(3);
videoEl.srcObject = null;

Fix
To not break backwards compatability, allow passing some optional config when calling unbindVideoElement that will detach the MediaStream.

Platform

  • All platforms
@p-foucht p-foucht added the Bug Something isn't working label Feb 19, 2021
@michhyun1 michhyun1 self-assigned this Feb 19, 2021
@michhyun1 michhyun1 removed their assignment Apr 28, 2021
@michhyun1
Copy link
Contributor

We want to invlude this change in the next major version update - it would be a breaking change to the current api definition.

@vidya-mohan vidya-mohan added video Issues related to quality of the video stream - blurry, jerky, freezes, black screens or unable to s builder labels Jun 9, 2021
@michhyun1 michhyun1 removed the builder label Jun 9, 2021
@xuesichao xuesichao added feature-request New feature or request and removed Bug Something isn't working labels Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request video Issues related to quality of the video stream - blurry, jerky, freezes, black screens or unable to s
Projects
None yet
Development

No branches or pull requests

4 participants