Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: java21 support in our build #1488

Merged
merged 4 commits into from
Oct 24, 2023
Merged

chore: java21 support in our build #1488

merged 4 commits into from
Oct 24, 2023

Conversation

jeromevdl
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Remove tests in examples (using mockito or not)
  • Configure mockito dependency depending on the jdk, using maven profiles
  • Adding java21 to the build

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jeromevdl
Copy link
Contributor Author

@scottgerring I know that's again a lot of stuff to port in v2 but now you know how to do :p (and we should do it right after merging this one).

@scottgerring scottgerring self-requested a review October 24, 2023 07:25
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

scottgerring
scottgerring approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeromevdl jeromevdl merged commit 228c0d8 into main Oct 24, 2023
16 checks passed
@jeromevdl jeromevdl deleted the chore/java21-support branch October 24, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottgerring scottgerring scottgerring approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeromevdl @scottgerring