-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACK Lambda and LogGroup Adopted resources default tags not getting updated #2163
Comments
@swapnachagam Hi! I am kindly asking you to add a proper formatting to your issue otherwise it is very difficult to read it. Particularly - indentation of logs and yamls. |
sorry i only attached the manifests. I have added the formatting now.. |
@swapnachagam Can you please share the manifests of the original manifests of the AoptedResource and the state of the lambda function? For LogGroups looks like we're missing the tags logic https://github.com/aws-controllers-k8s/cloudwatchlogs-controller/blob/main/pkg/resource/log_group/hook.go |
@a-hilaly Please find the manifest for loggroup adopted resource. I will share the lambdaFunction one shortly. I have recreate this. Yes we don't have tags, can we add the tags to the loggroups and also for lambdaFunctions?
|
@swapnachagam again please fix formatting. |
I am not able to fix the formatting but i have attached the logs here as file |
apiVersion: services.k8s.aws/v1alpha1
kind: AdoptedResource
metadata:
creationTimestamp: '2024-09-04T16:18:30Z'
finalizers:
- finalizers.services.k8s.aws/AdoptedResource
generation: 1
name: dexp-c-uw2-kinesis-firehose-logs-transformer-test
namespace: dexp-c-aws-781371715081
resourceVersion: '1770078'
uid: 335f7aff-74ed-4679-960e-78e52f1f732b
status:
conditions:
- status: 'True'
type: ACK.Adopted
spec:
aws:
nameOrID: /aws/lambda/dexp-c-uw2-KinesisFirehoseCWLogsTransformertest
kubernetes:
group: cloudwatchlogs.services.k8s.aws
kind: LogGroup
metadata:
name: dexp-c-uw2-kinesis-firehose-logs-transformer-test
namespace: dexp-c-aws-781371715081 I did it on your behalf :-) |
Attaching the lambda adopted resource manifests. Thank you for the above i am still not able to properly format
One more thing I want to double check if any updates made to the resource after being adapted, will ACK controller keep track of it? |
use three
signs before and three signs
after the text - it is typical markdown. |
Can i get an ETA for this issue please? |
cc @aws-controllers-k8s/lambda-maintainer |
I need an update for LogGroups as tags are not updated for log groups mainly. Lambda seems to be intermittent for me. Thank you |
Describe the bug
I am trying to adopt the existing Lambda function and LogGroup along with IAM Roles, Policies and s3 Buckets for my project.
All the resources except lambda and loggroup have below default tags added as soon as ACK Controllers adopted them
Expected tags post ACK adoption
services.k8s.aws/controller-version
services.k8s.aws/namespace
Steps to reproduce
Manifest of the adopted resource
Expected outcome
Adopted resource should have the default tags.
Environment
The text was updated successfully, but these errors were encountered: