In Node.js 12 or newer, add hasColors to the fake TTY methods #2170
Labels
bug
current functionality does not work as desired
💵 Funded on Issuehunt
This issue has been funded on Issuehunt
help wanted
We're missing
hasColors()
in our fake TTY implementation: https://github.com/avajs/ava/blob/533ee4bc54cbcd1c2b6ab5c67f3ec8a699965269/lib/worker/fake-tty.jsIt was introduced in Node.js 11, so we should check if the worker is running in Node.js 12 before adding it (Node.js 11 is end of life, see #2169). We should be able to piggy-back off of the
colorDepth
value that's already available. I don't think we can make it work with arbitraryenv
variables though. We can deal with that as a follow-up.Currently this is causing CI to fail with Node.js 12.5.0: https://travis-ci.org/avajs/ava/jobs/552425902
IssueHunt Summary
Backers (Total: $40.00)
Become a backer now!
Or submit a pull request to get the deposits!
Tips
IssueHunt has been backed by the following sponsors. Become a sponsor
The text was updated successfully, but these errors were encountered: