Add Unit Test for Test Aggregate Signatures #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusha-ctrl
requested review from
ceyonur,
darioush and
aaronbuchwald
as code owners
darioush
reviewed
Oct 4, 2023
warp/aggregator/aggregator_test.go
Outdated
| require.ErrorIs(t, err, context.Canceled) | ||
| return nil, err | ||
| default: | ||
| // We should not be able to get this signature since context cancelled in another go routine |
There was a problem hiding this comment.
if this is the case then is it necessary to add this expected call to the mock?
if it's necessary, could we factor out the common code here (eg calling client.EXPECT() in a loop)
There was a problem hiding this comment.
I see, I can remove the default case then. I just thought it would be more clear that this case would NOT happen.
darioush
approved these changes
Oct 4, 2023
aaronbuchwald
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This unit test simulates the scenario where the context is canceled midway through signature fetching.
All signature fetching go routines prior to cancellation should be able to get a signature.
All signature fetching go routines after cancellation should return with context cancelled error and no signature.
How this works
The result should have an aggregate signature from only one validator.
How this was tested
Only adds a UT. No actual change to any prod code.
How is this documented
UT is commented.