Ensure gas limit in genesis is consistent #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
added a commit
to ava-labs/avalanche-ops
that referenced
this pull request
Mar 16, 2022
ref. ava-labs/subnet-evm#63 Signed-off-by: Gyuho Lee <gyuho.lee@avalabs.org>
patrick-ogrady
force-pushed
the
ensure-consistent-gasLimit
branch
from
5044ba6
to
a79cddd
Compare
patrick-ogrady
commented
Mar 16, 2022
| @@ -184,6 +184,11 @@ func SetupGenesisBlock(db ethdb.Database, genesis *Genesis) (*params.ChainConfig | |||
| if genesis.Config == nil { | |||
| return nil, errGenesisNoConfig | |||
| } | |||
| // Make sure genesis gas limit is consistent | |||
| gasLimitConfig := genesis.Config.FeeConfig.GasLimit.Uint64() | |||
There was a problem hiding this comment.
We could choose to only do this on a go-forward basis. (i.e. if genesis doesn't exist)
There was a problem hiding this comment.
This is obviously not a great solution because old validators can continue fine but new validators won't be able to join.
patrick-ogrady
requested review from
aaronbuchwald,
gyuho,
hexfusion and
darioush
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an error when the
gasLimitspecified in the genesis header does not match thegasLimitspecified in theFeeConfig.