Genesis update #571
Closed
Genesis update #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* place and save order onchain * execute matched orders * changes based on PR comments
* Send a sample tx when a tx is received It goes into an infinite loop right now * add limit order processor * Add ABI parser * Remove hardcoded ABI * Order book (#1) * place and save order onchain * execute matched orders * changes based on PR comments * Make contarct call to OrderBook * add limit_order database layer to store and get limit_orders from sqlite database * Fix contract calls to OrderBook * Insert orders in sqlite database Read transactions and insert/update orders in database * Fix db tests * fix tests * check for price equality in GetLimitOrderByPositionTypeAndPrice method * return status in limit_orders in GetLimitOrder method * add test for updatelimit order status method * Add new run script * Review changes * Execute orders after block production * Store orders in memory and send tx at buildBlock * return if len of transaction input data is less than 4 fields * fix tests * change public methods to private and use them * add test for limit_order * add test for NewLimitOrderProcessor * minor refactoring Co-authored-by: vipul sharma <vipulsharma2190@gmail.com> Co-authored-by: asquare <21087753+asquare08@users.noreply.github.com>
* orderbook as genesis * reduce blocktime and clean tests * fix tests Co-authored-by: Atul Agarwal <21087753+asquare08@users.noreply.github.com>
* add tests for memory_database * add GetOrdersByPriceAndPositionType method * remove execute test order and add logic for matching limit orders and making contract call * refactoring limit_order private methods * add OrderMatched event in orderbook contract and test event generation * log error is baseAssetQuantity is zero, add method for position type * break matching limit order loop if matching order is found * Use contract address instead of ABI for parseTx * Use ChainAcceptedEvent instead of NewHeadEvent * fix syntax error * refactor memory_database and remove matching logic from limit_order * add limit order matching engine and call it during buildblock * add purge local tx before running matching logic * minor fixes * check executeMatchedOrder tx status before deleting limit orders * delete pending executeMatchedOrders txs before running matching engine Co-authored-by: Shubham Goyal <sgshubham@gmail.com>
… limit_order dependencies in vm.go
refactor limit_order to move out limit_order_txs logic
…oreLimitOrderTransactions
* add filledBaseAssetQuantity in limit order * fix tests * add test for RunMatchingEngine * pull changes from hubble-v2 * remove sqlite database files * add LimitOrderDatabase interface and implement in inMemoryDatabase * deven|fdgod create LimitOrderTxProcessor interface * deven|fdgod add tests for limit_order and mocks for LimitOrderDatabase and LimitOrderTxProcessor * add tests for RunMatchingLogic in limit_order * fix previous tests * change memory_database to return object instead of pointer to limit_orders stored in memory_database * change matching logic to partial match limit orders with different BaseAssetQuantity * change ExecuteMatchedOrdersTx as per new contract * delete order if filledBaseAssetQuantity is equal to BaseAssetQuantity * update filledBaseAssetQuantity after parsing executeMatchedOrders * return LimitOrder instead of pointer in its memory_database * add test for GetOrder * return InMemoryDatabase from NewInMemoryDatabase and remove GetOrder function * remove GetOrder method from mocks * change salt to int64 * convert fillAmount to uint * add parsing logic for two orders in function input and output * pass orders with type Order to executeMatchedOrders tx * change logic of skipping already filled orders in RunMatchingEngine method in limit_order * refactor code
#13) * change price check in matching engine to match if longOrder price >= shortOrder price * more aggresive assertions * Add tests for getUnFilledBaseAssetQuantity * refactor TestGetUnfilledBaseAssetQuantity * refactor RunMatchingEngine in limit_order and add tests Co-authored-by: atvanguard <3612498+atvanguard@users.noreply.github.com>
* add genesis contracts * update orderbook.sol * update comments * precision
* funding skeleton * Handle events and add liquidation logic * Fix merge errors * minor fixes * Ignore orders matched during liquidation for matching * add tests for UpdateMargin, UpdatePosition, UpdateUnrealisedFunding method in memory_database * check for presence of positions for address in ResetUnrealisedFunding and add tests * fix tests * add lastPrice when db initialized and add tests * Liquidation and UnrealisedFunding fixes * Review changes * Use big.Int everywhere * add functions specified in LimitOrderTxProcessor interface * fix liquidations compare marginFraction logic * check if position nil in UpdateUnrealisedFunding and fix tests * Add missing file * Fetch all logs at once * Add missing file * fix: Change multiplication factor * purge liquidateAndExecuteOrder and settleFunding tx * Fix precision handling * refactor liquidations and add tests * Review fixes * fix tests * Fix incorrect amounts in runLiquidations * Fix errors after merge * fix tests * fix tests * add genesis contracts + mocked orderBook (#14) * add genesis contracts * update orderbook.sol * update comments * precision * Review fixes * Handle OrderCancelled * Pass notionalPosition in function * fix tests * Review fixes * Change IsFundingPaymentTime Co-authored-by: Shubham Goyal <sgshubham@gmail.com> Co-authored-by: fdgod <vipulsharma2190@gmail.com>
expose api which return all database data
* move liquidations from database and change GetLiquidations into a standalone pure function, fix tests * move out contract events processor from limit_order_tx_processor and add tests
…lock there, add tests for run liquidations
refactor limit_order.go and add unit tests
* fix tests and some refactoring * add test for cancelOrder event and some refactoring * remove nil check on order
* add genesis contract interfaces * abis.go --------- Co-authored-by: Shubham Goyal <sgshubham@gmail.com>
* Run and upgrade scripts using avalanche cli * Add logs handling in new scripts * Handle when multitail is not installed
0xshinobii
requested review from
anusha-ctrl,
ceyonur,
darioush and
aaronbuchwald
as code owners
ceyonur
added a commit
that referenced
this pull request
Jun 6, 2024
* remove notes/ (#571) * Remove optional gatherer (#563) * Remove optional gatherer * nit * Do not register chain state metrics when metrics are disabled --------- Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> * add compatibility for v0.6.6 * update avago in readme --------- Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
increase test account gas token balance for multiple order matching testing